Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Routable derive macro hygienic #3437

Merged
merged 1 commit into from
Jan 1, 2025

Conversation

MrGVSV
Copy link
Contributor

@MrGVSV MrGVSV commented Dec 22, 2024

Makes the Routable derive macro hygienic by wrapping the output in an anonymous scope.

This allows multiple routers to be defined in the same scope if necessary (e.g. for testing purposes, macro generation, etc.).

@jkelleyrtp jkelleyrtp merged commit 04282ef into DioxusLabs:main Jan 1, 2025
16 of 17 checks passed
@jkelleyrtp
Copy link
Member

Thank you!

@MrGVSV MrGVSV deleted the mrgvsv/router/macro-hygiene branch January 2, 2025 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants