fix(cli): get ip addr & port number from config #3369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiseaidev
force-pushed
the
cli-ssg-addr
branch
from
cb3ec10 to
802d49c
Compare
|
Good catch - I didn't think it would be important to pass the port/address through but in hindsight some features do care about these values (like side apis and cli_config) |
jkelleyrtp
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been experimenting with Dioxus SSG recently and noticed that the port number and IP address are hardcoded. The port is set to
9999instead of retrieving the values from the configuration.With these changes, the port is now set to the env var value at compile time (defaults to 8080):