Fix hydration of suspense fragments that contain text nodes #3287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ealmloff
added
bug
ealmloff
commented
Dec 7, 2024
| /// Create a new meta tag in the head | ||
| fn create_meta(&self, props: MetaProps) { | ||
| let myself = self.clone(); | ||
| queue_effect(move || { |
There was a problem hiding this comment.
Ideally these would be a default implementation, but it requires a Clone bound on the document trait for queue_effect which is a breaking change
ealmloff
commented
Dec 7, 2024
| @@ -13,27 +13,26 @@ pub(crate) fn RootScopeWrapper(props: RootProps<VComponent>) -> Element { | |||
| None, | |||
| TEMPLATE, | |||
| Box::new([DynamicNode::Component( | |||
| fc_to_builder(ErrorBoundary) | |||
| .children(Element::Ok(VNode::new( | |||
| fc_to_builder(SuspenseBoundary) | |||
There was a problem hiding this comment.
This was not causing the hydration error, but putting the error boundary inside the suspense boundary makes it possible to resolve the error on the server without javascript instead of waiting and resolving the error on the client (we added support in #2772, but it is still slower when we can avoid it)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The node walker that hydrates streaming fragments in fullstack was walking some nodes twice which took too many ids off of the stack. This PR fixes that issue and adds more debug information for data hydration failures in debug mode
use_server_futureHydration error #3041use_server_futureHydration error #3041Fixes #3041
Fixes #3299