Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README updated with new map set-up documentation #2

Merged
merged 7 commits into from
Jul 25, 2024
Merged

Conversation

ms0ur1s
Copy link
Contributor

@ms0ur1s ms0ur1s commented Sep 18, 2023

What

Updated README to include the process for creating a new map.

How

Based on my experiences creating the Mesopotamia map with Nick, I documented the process for using the mykomap-site-example repo as the basis for a new, deployable MykoMap.

@ms0ur1s ms0ur1s self-assigned this Sep 18, 2023
@ms0ur1s ms0ur1s requested a review from wu-lee September 18, 2023 10:22
@ms0ur1s ms0ur1s changed the title README updated with new man set-up documentation README updated with new map set-up documentation Sep 18, 2023
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I try step 3 it doesn't work:

$ git mv mykomap-site-example/ my-new-mykomap/

When I do it literally as written, from my-new-mykomap, I get:

fatal: bad source, source=gitworking/Code-Operative/SEA/my-new-mykomap/mykomap-site-example, destination=gitworking/Code-Operative/SEA/my-new-mykomap/my-new-mykomap/

When I do it from the shared parent directory, I get:

fatal: source directory is empty, source=gitworking/Code-Operative/SEA/mykomap-site-example, destination=gitworking/Code-Operative/SEA/my-new-mmm/mykomap-site-example

I don't know if the git-clone will work as-is either? It might if you're in the parent directory.

This might be how I'd do the job:

# Use the URL from the GitHub repo you want to copy
git clone --depth 1 [email protected]:DigitalCommons/mykomap-site-example.git my-new-mykomap
cd my-new-mykomap

rm -rf .git # blows away the old git database
git init # creates a new one

# commit the files
git add -A
git commit -m "initial commit"

# add back origin/remote (assumes the project has been created)
git remote add origin [email protected]:DigitalCommons/my-new-mykomap
git push --set-upstream origin/master  # (or use origin/main if the project uses that)

(That git remote add command might be equivalent to your set-url version, I didn't check fully)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wu-lee, is it ok for me to create a temporary repo to check the process and update the documentation?

@wu-lee wu-lee force-pushed the new-map-setup-doc branch from 5caec8f to 217b344 Compare December 1, 2023 13:11
@wu-lee
Copy link
Contributor

wu-lee commented Dec 4, 2023

@ms0ur1s - I could add in some of these things as part of the work for rolling out the next map. Do you want to respond to anything here, or make any amendments first?

@lin-d-hop
Copy link

This is a great issue :)

As a rule of thumb for README bits, let's focus on improvements rather than perfection. READMEs can always be iterated and updated with each new person setting up :)

@lin-d-hop
Copy link

@ms0ur1s this issue has been sitting here a while.
Is there a reason you're avoiding it? If so let's figure out how to unblock those reasons.
If the issue is no longer valid then let's close it :)

@ms0ur1s
Copy link
Contributor Author

ms0ur1s commented Apr 30, 2024

Is there a reason you're avoiding it? If so let's figure out how to unblock those reasons. If the issue is no longer valid then let's close it :)

No @lin-d-hop, it's just me putting off the less glamorous work. 😁 I'll make this my first job tomorrow.

Once it's done I'll create a wiki update the README.

@ms0ur1s
Copy link
Contributor Author

ms0ur1s commented May 1, 2024

@ms0ur1s - I could add in some of these things as part of the work for rolling out the next map. Do you want to respond to anything here, or make any amendments first?

No, I'm happy with everything you said. Thanks for the help and apologies for not replying earlier. I just keep pushing this ticket just out of sight 😁. I'll do another test set up and add a wiki entry update the README.

@ms0ur1s
Copy link
Contributor Author

ms0ur1s commented May 9, 2024

@wu-lee, I've updated the README file, do you mind giving it a once-over?
https://github.com/DigitalCommons/mykomap-site-example/blob/new-map-setup-doc/README.md

Also, do filterable fields still need to be vocabs? If so I'll add this to the documentation.

@wu-lee
Copy link
Contributor

wu-lee commented Jun 5, 2024

@wu-lee, I've updated the README file, do you mind giving it a once-over? https://github.com/DigitalCommons/mykomap-site-example/blob/new-map-setup-doc/README.md

I gave it a read through - found and fixed a couple of very minor spelling/punctuation things - but otherwise I think as @lin-d-hop says, if there are any more improvements they can be added in the context of future usages of this documentation.

Also, do filterable fields still need to be vocabs? If so I'll add this to the documentation.

Hm, I think they do. This is one thing we want to fix, however - when it gets to the top of the priority queue! So I guess add it, and we can take it out again as part of DigitalCommons/mykomap#201.

@ms0ur1s ms0ur1s merged commit 6cd8219 into main Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants