Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor text issues #91

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Minor text issues #91

merged 4 commits into from
Nov 22, 2024

Conversation

ms0ur1s
Copy link
Contributor

@ms0ur1s ms0ur1s commented Nov 22, 2024

What? Why?

Related to issue #82

  • Update title to 'Cooperative World Map'
  • Added CWM favicon
  • Added CwmLogo component and updated map attribution control within mapLibre.ts to reduce size on mobile.
  • Update translation key for no location message

Checklist

  • Updated or added any necessary docs in docs/
  • Added UTs
  • Checked that all automated tests pass

What should we test? (for QA)

  • Check that the relevant browser tab shows the CWM favicon and the updated title
    image
  • Check the logo position on both desktop and mobile
  • Check the pop-up translation for no_location_data_available

@ms0ur1s ms0ur1s requested a review from rogup November 22, 2024 18:37
@rogup rogup force-pushed the minor-text-issues branch from 2f3cd1e to 13531a5 Compare November 22, 2024 20:58
@rogup rogup merged commit 2e5b07b into dev Nov 22, 2024
1 check passed
@rogup rogup deleted the minor-text-issues branch November 22, 2024 21:00
@rogup
Copy link
Contributor

rogup commented Nov 22, 2024

Looks good, just removed the no location data string commit, since it's not needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants