Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #541 seeding input optional labor #547

Conversation

JingyuMarcelLee
Copy link
Collaborator

Pull Request Description

Fixes issue #541. Now the Input form works as intended when an optional labor configuration is selected. However, it fails to address the firefox bug of returning an empty string when invalid input is entered. This bug is described at #546.


Licensing Certification

FarmData2 is a Free Cultural Work and all accepted contributions are licensed as described in the LICENSE.md file. This requires that the contributor holds the rights to do so. By submitting this pull request I certify that I satisfy the terms of the Developer Certificate of Origin for its contents.

@braughtg braughtg merged commit b96a568 into DickinsonCollege:main Jul 21, 2022
@JingyuMarcelLee JingyuMarcelLee deleted the issue541_seedingInputOptionalLabor branch July 21, 2022 19:14
@JingyuMarcelLee JingyuMarcelLee restored the issue541_seedingInputOptionalLabor branch July 21, 2022 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants