Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qwatch integration tests with where condition and benchmarking #438

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Qwatch integration tests with where condition and benchmarking #438

wants to merge 3 commits into from

Conversation

deep-adeshraa
Copy link

@deep-adeshraa deep-adeshraa commented Sep 1, 2024 •
edited
Loading

fixes #188
Integration test case for Qwatch with where condition and benchmarking for Qwatch with SET commands.

@deep-adeshraa deep-adeshraa changed the title Qwatch with where condition integration and benchmarking Qwatch integration tests with where condition and benchmarking Sep 1, 2024
@deep-adeshraa
Copy link
Author

@JyotinderSingh Benchmarking QWATCH with large number of requests fails the I/O test cases. I have commented out benchmarking code. If you could guide me to navigate the bug, I will be happy to solve it.

@JyotinderSingh
Copy link
Collaborator

@JyotinderSingh Benchmarking QWATCH with large number of requests fails the I/O test cases. I have commented out benchmarking code. If you could guide me to navigate the bug, I will be happy to solve it.

We are making some changes to the QWATCH feature. It might help with some of these issues.
We can re-explore this over the weekend (since the qwatch changes would be merged by then)

@JyotinderSingh
Copy link
Collaborator

Please rebase the PR, we just had a large change go in which might've introduced conflicts.

@deep-adeshraa deep-adeshraa mentioned this pull request Sep 9, 2024
Open
@JyotinderSingh
Copy link
Collaborator

@JyotinderSingh Benchmarking QWATCH with large number of requests fails the I/O test cases. I have commented out benchmarking code. If you could guide me to navigate the bug, I will be happy to solve it.

We are making some changes to the QWATCH feature. It might help with some of these issues. We can re-explore this over the weekend (since the qwatch changes would be merged by then)

Can you test the benchmarking code again with the latest changes? I have introduced some changes which should help prevent the errors you may be seeing earlier.

@JyotinderSingh
Copy link
Collaborator

@deep-adeshraa are you still working on this?

@deep-adeshraa
Copy link
Author

@JyotinderSingh give me this weekend last - I will finish it up with new code you guys added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JyotinderSingh JyotinderSingh Awaiting requested review from JyotinderSingh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add integration test for testing WHERE clause in QWATCH.
2 participants
@deep-adeshraa @JyotinderSingh