Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] refactor: config management #1239

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vinitparekh17
Copy link
Contributor

[generated by github copilot]

This pull request introduces a new configuration parser, updates configuration files, and modifies test setup and dependencies. The most important changes include the addition of a new ConfigParser in config/parser.go, updates to configuration files, and adjustments in test setup and dependency management.

Configuration Management:

  • config/parser.go: Added a new ConfigParser to handle parsing configuration files and unmarshalling configuration values into structs. This parser supports reading from files, stdin, and setting default values.

Configuration Files:

  • dice.conf: Added a new configuration file for Dicedb with various settings including server, HTTP, WebSocket, performance, memory, persistence, logging, authentication, and network configurations.
  • dice.toml: Removed the old TOML configuration file that included similar settings to the new dice.conf file.

Dependency Management:

  • go.mod: Removed several indirect dependencies and added github.com/kr/pretty as a new indirect dependency. [1] [2]

Test Setup Adjustments:

Test Improvements:

@vinitparekh17 vinitparekh17 marked this pull request as draft November 5, 2024 20:53
@vinitparekh17
Copy link
Contributor Author

Although it is work in progress, I am open for suggestions and feedback from the community. @JyotinderSingh @lucifercr07 @soumya-codes @arpitbbhayani @apoorvyadav1111

@vinitparekh17
Copy link
Contributor Author

pending changes,

  • test cases for new implementation
  • stable support for sub cmd / flags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant