Skip to content

Conversation

@callumforrester
Copy link
Contributor

Fix unit tests by defining the path provider in a fixture, this is needed pending DiamondLightSource/dodal#1129

Fix unit tests by defining the path provider in a fixture, this is needed pending DiamondLightSource/dodal#1129
@codecov
Copy link

codecov bot commented Aug 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (7c22096) to head (bfa21e0).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #15   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           34        33    -1     
=========================================
- Hits            34        33    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@GDYendell GDYendell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something I was wondering: is there any reason to use the decorator on snapshot but not spectroscopy?

@callumforrester
Copy link
Contributor Author

As it is spectroscopy is calling spec_scan, which has the decorator. snapshot is calling bluesky.plans.count, which does not, so it needs its own. You could instead make it call dodal.plans.count, which is just a decorated wrapper. However now we're using numtracker the decorator is also a no-op so we can actually just get rid of it.

@callumforrester callumforrester merged commit ef8e206 into main Aug 8, 2025
8 checks passed
@callumforrester callumforrester deleted the fix-unit-tests branch August 8, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants