Wait on prepare when setting exposure time #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 34 34
=========================================
Hits 34 34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Wait on prepare when setting exposure time to avoid race conditions, add a test to show that the plan prepares and then waits before doing anything else
callumforrester
force-pushed
the
fix-exp-time
branch
from
da25a41 to
dddb61e
Compare
callumforrester
changed the title
Update test configuration to be compatible with blueapi 1.0.1
callumforrester
force-pushed
the
fix-exp-time
branch
from
14cf543 to
263564e
Compare
GDYendell
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to pass
wait=Truetoprepareto avoid race conditions when actually acquiring data, otherwiseprepare's operations may not be complete when acquisition starts.