Skip to content

Conversation

@Relm-Arrowny
Copy link
Collaborator

@Relm-Arrowny Relm-Arrowny commented Sep 5, 2025

Fixes #99

Re-factor fast_scan:

  • Added cache and restore_speed to plan stub motion for restoring speed of motor.
  • Change plan_stubs detector plans to detection and added fly_trigger and read to do software trigger scan.
  • Added soft_fly_energy_scan to fast_scan.py.
  • Move random detector to conftest.py
  • Added i10 lookup table for testing.

Instructions to reviewer on how to test:

  1. Run test.
  2. Confirm it pass and re factoring make sense.

Checks for reviewer

  • Would the PR title make sense to a user on a set of release notes

@Relm-Arrowny Relm-Arrowny linked an issue Sep 5, 2025 that may be closed by this pull request
5 tasks
@codecov
Copy link

codecov bot commented Sep 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.42%. Comparing base (d6c139d) to head (4e12bd6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
+ Coverage   98.34%   98.42%   +0.07%     
==========================================
  Files          25       25              
  Lines         605      634      +29     
==========================================
+ Hits          595      624      +29     
  Misses         10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Relm-Arrowny Relm-Arrowny changed the title make common cache speed plan Fast energy scan plan Sep 11, 2025
@Relm-Arrowny Relm-Arrowny requested a review from a team September 15, 2025 13:55
@Relm-Arrowny Relm-Arrowny marked this pull request as ready for review September 15, 2025 13:55
async def mock_pgm(prefix: str = "BLXX-EA-DET-007:") -> FakePGM:
async with init_devices(mock=True):
mock_pgm = FakePGM()
return mock_pgm
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why create a FakePGM, surely you can just use PGM device in mock mode and then use patch_mock_motor with it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need simMotor rather than just mock, I need the motor to be non instant to test flying scan.

@Relm-Arrowny
Copy link
Collaborator Author

This is waiting for dodal#1467

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A fast energy scan plan (software)

3 participants