-
Notifications
You must be signed in to change notification settings - Fork 0
Fast energy scan plan #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
==========================================
+ Coverage 98.34% 98.42% +0.07%
==========================================
Files 25 25
Lines 605 634 +29
==========================================
+ Hits 595 624 +29
Misses 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| async def mock_pgm(prefix: str = "BLXX-EA-DET-007:") -> FakePGM: | ||
| async with init_devices(mock=True): | ||
| mock_pgm = FakePGM() | ||
| return mock_pgm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why create a FakePGM, surely you can just use PGM device in mock mode and then use patch_mock_motor with it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need simMotor rather than just mock, I need the motor to be non instant to test flying scan.
|
This is waiting for dodal#1467 |
Fixes #99
Re-factor fast_scan:
Instructions to reviewer on how to test:
Checks for reviewer