Skip to content

Conversation

@olliesilvester
Copy link
Contributor

@olliesilvester olliesilvester commented Mar 19, 2025

To do:

  • Smargon shouldn't be required by the plan -we currently only use the omega motor, and that's only to set it to 0
  • Think about putting snapshots to ispyb. Currently, GDA can just send them over. Fastest short team solution would just be for the entry plan to push these to ispyb before doing anything else. Long term solution is to actually take the snapshots in bluesky
  • Stop defaulting parameters to i03 and instead make them required - eg beamline and insertion_prefix
  • Make sure detector isn't asked to move during gridscan. Vmxm move their detector manually only

Fixes #ISSUE

Link to dodal PR (if required): #XXX
(remember to update pyproject.toml with the dodal commit tag if you need it for tests to pass!)

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a user on a set of release notes

olliesilvester and others added 30 commits February 4, 2025 13:28
@codecov
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 92.23602% with 25 lines in your changes missing coverage. Please review.

Project coverage is 87.72%. Comparing base (5b6c3fe) to head (d8a439a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #924      +/-   ##
==========================================
- Coverage   87.81%   87.72%   -0.09%     
==========================================
  Files         107      113       +6     
  Lines        7195     7293      +98     
==========================================
+ Hits         6318     6398      +80     
- Misses        877      895      +18     
Components Coverage Δ
i24 SSX 74.16% <ø> (ø)
hyperion 96.13% <98.24%> (-0.22%) ⬇️
other 96.79% <88.94%> (-0.56%) ⬇️
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DominicOram DominicOram added the vmxm Changes relating to VMXm label Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

vmxm Changes relating to VMXm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants