1318 optimise oav transmission new #1473
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and the frac_of_max + add docstrings
DominicOram
reviewed
Dec 8, 2025
Contributor
DominicOram
left a comment
DominicOram
left a comment
There was a problem hiding this comment.
Added some notes for myself. I will address these
Comment on lines
+82
to
+84
| Args: | ||
| devices: These are the specific ophyd-devices used for the plan, the | ||
| defaults are always correct. |
Contributor
There was a problem hiding this comment.
Should: Not sure I like having the args not matching the actual names of the args. Also, there are no defaults and group is not a device
| max_pixel: MaxPixel = inject("max_pixel"), | ||
| attenuator: BinaryFilterAttenuator = inject("attenuator"), | ||
| ): | ||
| yield from bps.mv(attenuator, 100) # 100 % transmission |
Contributor
There was a problem hiding this comment.
Must: Attenuator takes transmission as a fraction, e.g. 0-1
| f"Testing transmission {mid}, brightest pixel found {brightest_pixel}" | ||
| ) | ||
|
|
||
| if target_pixel_l - tolerance < brightest_pixel < target_pixel_l + tolerance: |
Contributor
There was a problem hiding this comment.
Should: I think there is the (very slim) potential for this to get stuck if brightest_pixel=target_pixel_l - tolerance or brightest_pixel=target_pixel_l + tolerance.
Contributor
|
An updated PR for the same changes is here - a lot of the comments here are still relevant though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1318
Instructions to reviewer on how to test:
Need to add tests.
Checks for reviewer