(Don't review) Working branch for vmxm testing #1214
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olliesilvester
force-pushed
the
refactor_common_gridscan
branch
from
7c547d9 to
5376471
Compare
…ocols to type sample stage
Contributor
Author
|
I will use this branch when testing on beamline next week, but this PR really needs to be split up a bit now, as it's a bit impossible to review like this
After these 3 are merged, the PR for adding vmxm's gridscan plan can be reviewed more easily |
Contributor
Author
|
Test failure is because there is no device called "grid_scan" in i03. Need to adjust the Hyperion composite device a bit for this |
olliesilvester
changed the title
olliesilvester
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.