Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using kill -INT $$ #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Avoid using kill -INT $$ #41

wants to merge 1 commit into from

Conversation

umireon
Copy link
Contributor

@umireon umireon commented Apr 9, 2017

Exit code is used to handle errors instead of signal.

Fixes #29

@umireon umireon force-pushed the avoid-using-kill-self branch from a7f8567 to 0548212 Compare April 9, 2017 14:38
@umireon
Copy link
Contributor Author

umireon commented Apr 9, 2017

path cannot be used as a variable name in zsh and that caused a CI failure.
Now the problem is fixed and a new commit was force-pushed.

@umireon umireon force-pushed the avoid-using-kill-self branch from 0548212 to 9a25cc5 Compare April 12, 2017 10:42
@umireon
Avoid using kill -INT $$
d30e774 
Exit code is used to handle errors instead of signal.

Fixes DhavalKapil#29
@umireon umireon force-pushed the avoid-using-kill-self branch from 9a25cc5 to d30e774 Compare April 12, 2017 11:54
@umireon
Copy link
Contributor Author

umireon commented Apr 12, 2017

Indentation error was fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@umireon