Server "resize" support #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"debug" level is a bit too verbose here. Signed-off-by: Marc-André Lureau <[email protected]>
So we can skip dumping the "data" field. Signed-off-by: Marc-André Lureau <[email protected]>
Teach the server to call a DisplayControlHandler to notify of monitor layout requests. Signed-off-by: Marc-André Lureau <[email protected]>
Move finalize phase to a separate function, so we can introduce common code for looping next, with deactivation-reactivation sequence. Also use anyhow::Context instead of manually handling errors. Signed-off-by: Marc-André Lureau <[email protected]>
Instead of reporting the error in various places, move error reporting code to one place and simplify a bit the code thanks for anyhow::Context and Result handling. Signed-off-by: Marc-André Lureau <[email protected]>
Use an explicit enum to return the client loop/run state from the handlers. This will allow to return a DeactivationReactivation sequence state from the display handler next. Signed-off-by: Marc-André Lureau <[email protected]>
So the function can be reused for deactivation-reactivation sequence. Signed-off-by: Marc-André Lureau <[email protected]>
Teach the acceptor to resume from the CapabilitiesSendServer state. Signed-off-by: Marc-André Lureau <[email protected]>
Trigger a deactivation-reactivation sequence to handle desktop resize. https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms-rdpbcgr/dfc234ce-481a-4674-9a5d-2a7bafb14432 Signed-off-by: Marc-André Lureau <[email protected]>
Signed-off-by: Marc-André Lureau <[email protected]>
Signed-off-by: Marc-André Lureau <[email protected]>
Signed-off-by: Marc-André Lureau <[email protected]>
CBenoit
approved these changes
Aug 14, 2024
|
|
||
| let res = ironrdp_acceptor::accept_begin(framed, &mut acceptor) | ||
| .await | ||
| .context("Accept begin error")?; |
There was a problem hiding this comment.
| self.static_channels.insert(channel); | ||
|
|
||
| // restore channel id if it was already attached |
There was a problem hiding this comment.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add deactivation-reactivation support to the server.
Add BitmapUpdate "stride" support, which helps/fixes qemu-rdp server for odd dimensions.