refactor(client): bump to winit 0.30 & fixes #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elmarco
force-pushed
the
client
branch
5 times, most recently
from
ca18381
to
41917a9
Compare
This was referenced Aug 7, 2024
pacmancoder
reviewed
Aug 7, 2024
pacmancoder
reviewed
Aug 7, 2024
pacmancoder
reviewed
Aug 7, 2024
CBenoit
reviewed
Aug 9, 2024
CBenoit
reviewed
Aug 9, 2024
Providing the andMask is not mandatory (https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms-rdpbcgr/71fad4fc-6ad4-4c7f-8103-a442bebaf7d2) Signed-off-by: Marc-André Lureau <[email protected]>
Create a hidden window instead. This allows for easier setup of clipboard channels while the GUI may not be ready yet. Signed-off-by: Marc-André Lureau <[email protected]>
Signed-off-by: Marc-André Lureau <[email protected]>
Signed-off-by: Marc-André Lureau <[email protected]>
This solves broken/crashing display on wayland with HiDPI. Signed-off-by: Marc-André Lureau <[email protected]>
Signed-off-by: Marc-André Lureau <[email protected]>
It should now be done from an ActiveEventLoop, during ApplicationHandler callbacks, like resumed(). Signed-off-by: Marc-André Lureau <[email protected]>
Signed-off-by: Marc-André Lureau <[email protected]>
Signed-off-by: Marc-André Lureau <[email protected]>
pacmancoder
approved these changes
Aug 9, 2024
yes! thanks |
CBenoit
reviewed
Aug 12, 2024
CBenoit
reviewed
Aug 12, 2024
CBenoit
reviewed
Aug 12, 2024
CBenoit
reviewed
Aug 12, 2024
CBenoit
reviewed
Aug 12, 2024
CBenoit
approved these changes
Aug 12, 2024
Comment on lines
+29
to
+39
| pub fn new( | ||
| event_loop: &EventLoop<RdpOutputEvent>, | ||
| input_event_sender: &mpsc::UnboundedSender<RdpInputEvent>, | ||
| ) -> anyhow::Result<Self> { | ||
| // SAFETY: We drop the softbuffer context right before the event loop is stopped, thus making this safe. | ||
| // FIXME: This is not a sufficient proof and the API is actually unsound as-is. | ||
| let display_handle = unsafe { | ||
| std::mem::transmute::<DisplayHandle<'_>, DisplayHandle<'static>>(event_loop.display_handle().unwrap()) | ||
| }; | ||
| let context = softbuffer::Context::new(display_handle) | ||
| .map_err(|e| anyhow::anyhow!("unable to initialize softbuffer context: {e}"))?; |
There was a problem hiding this comment.
issue: We can’t actually guarantee that event_loop is dropped after the context at this point, we are not the ones owning it. Only the owner can guarantee that, and thus it’s only possible to know that at the call site. As such, this API is unsound and the unsafe block may cause an undefined behavior in the future if we misuse the API. I don’t consider this a blocker since this is not part of the public API of the IronRDP crates, and we can address that in the future.
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update code to winit 0.30, various large refactoring necessary.
Related fixes.
My main motivation was fixeing a crash on wayland with HiDPI, and also use update to latest crates.
Fixes: #375
Fixes: #521
Fixes: #522