Fixed presentation transition getting skipped

Developer-Mike · Jan 13, 2025 · ba1dc04 · ba1dc04
1 parent aff37b9
commit ba1dc04
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/src/canvas-extensions/presentation-canvas-extension.ts b/src/canvas-extensions/presentation-canvas-extension.ts
@@ -262,11 +262,14 @@ export default class PresentationCanvasExtension extends CanvasExtension {
 
       await sleep(animationDurationMs / 2)
 
-      const nextNodeBBoxEnlarged = BBoxHelper.scaleBBox(toNode.getBBox(), animationIntensity)
-      if (useCustomZoomFunction) CanvasHelper.zoomToBBox(canvas, nextNodeBBoxEnlarged)
-      else canvas.zoomToBbox(nextNodeBBoxEnlarged)
+      if (fromNode.getData().id !== toNode.getData().id) {
+        // Add 0.1 to fix obsidian bug that causes the animation to skip if the bbox is the same
+        const nextNodeBBoxEnlarged = BBoxHelper.scaleBBox(toNode.getBBox(), animationIntensity + 0.1)
+        if (useCustomZoomFunction) CanvasHelper.zoomToBBox(canvas, nextNodeBBoxEnlarged)
+        else canvas.zoomToBbox(nextNodeBBoxEnlarged)
 
-      await sleep(animationDurationMs / 2)
+        await sleep(animationDurationMs / 2)
+      }
     }
 
     let nodeBBox = toNode.getBBox()

diff --git a/src/utils/canvas-helper.ts b/src/utils/canvas-helper.ts
@@ -153,6 +153,10 @@ export default class CanvasHelper {
   }
 
   static zoomToBBox(canvas: Canvas, bbox: BBox) {
+    /* const zoomX = canvas.canvasRect.width / (1.1 * (bbox.maxX - bbox.minX))
+    const zoomY = canvas.canvasRect.height / (1.1 * (bbox.maxY - bbox.minY))
+    const zoom = Math.clamp(Math.min(zoomX, zoomY), -4, 1) */
+
     const PADDING_CORRECTION_FACTOR = 1 / 1.1
     const zoomedBBox = BBoxHelper.scaleBBox(bbox, PADDING_CORRECTION_FACTOR)