Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reexports #1206

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add reexports #1206

wants to merge 6 commits into from

Conversation

Igggr
Copy link
Contributor

@Igggr Igggr commented Oct 18, 2021

https://trello.com/c/HzUtQKx1/1060-add-reexports-to-wrapper-packages

devextreme-angular/dist/ui/vector-map/index.ts

+ export {
+  CenterChangedEvent,
+  ClickEvent,
+  DisposingEvent,
+  DrawnEvent,
+  ExportedEvent,
+  ExportingEvent,
+  FileSavingEvent,
+  IncidentOccurredEvent,
+  InitializedEvent,
+  OptionChangedEvent,
+  SelectionChangedEvent,
+  TooltipHiddenEvent,
+  TooltipShownEvent,
+  ZoomFactorChangedEvent,
+  MapLayer,
+  MapLayerElement,
+  LegendItem,
+  dxVectorMapAnnotationConfig,
+  dxVectorMapCommonAnnotationConfig,
+ } from 'devextreme/viz/vector_map';


import { BrowserTransferStateModule } from '@angular/platform-browser';
import { TransferState } from '@angular/platform-browser';

must change generation of devextreme-angular/dist/index.ts (otherwise reexports from different files will clash

export * from 'devextreme-angular/core';
export * from './ui/all';
- export * from 'devextreme-angular/ui/accordion';
- export * from 'devextreme-angular/ui/action-sheet';
- export * from 'devextreme-angular/ui/autocomplete';
- export * from 'devextreme-angular/ui/bar-gauge';
- export * from 'devextreme-angular/ui/box';
- export * from 'devextreme-angular/ui/bullet';
- export * from 'devextreme-angular/ui/button-group';
- export * from 'devextreme-angular/ui/button';
- export * from 'devextreme-angular/ui/calendar';
- export * from 'devextreme-angular/ui/chart';
+ export { DxAccordionComponent, DxAccordionModule } from 'devextreme-angular/ui/accordion';
+ export { DxActionSheetComponent, DxActionSheetModule } from 'devextreme-angular/ui/action-sheet';
+ export { DxAutocompleteComponent, DxAutocompleteModule } from 'devextreme-angular/ui/autocomplete';
+ export { DxBarGaugeComponent, DxBarGaugeModule } from 'devextreme-angular/ui/bar-gauge';
+ export { DxBoxComponent, DxBoxModule } from 'devextreme-angular/ui/box';
+ export { DxBulletComponent, DxBulletModule } from 'devextreme-angular/ui/bullet';
+ export { DxButtonGroupComponent, DxButtonGroupModule } from 'devextreme-angular/ui/button-group';
+ export { DxButtonComponent, DxButtonModule } from 'devextreme-angular/ui/button';
+ export { DxCalendarComponent, DxCalendarModule } from 'devextreme-angular/ui/calendar';
+ export { DxChartComponent, DxChartModule } from 'devextreme-angular/ui/chart';

@Igggr Igggr self-assigned this Oct 18, 2021
});

logger('Write result to ' + facadeFilePath);
fs.writeFileSync(facadeFilePath, resultContent, { encoding: this._encoding });
});
}
}


function formatName(name: string): string {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we re-use prepareModuleName from module.facade-generator?

Copy link
Contributor Author

@Igggr Igggr Oct 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, can't. it first merged strings, and then camilized. And here i need first camilized and then merge. Also it add Module in the end, end i need one Module and one component

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants