Feature/intergration tests #15
Conversation
Following the issue to change to circleci
|
Choice can be made to run on all branches or just master. What do you think? |
|
Maybe have it on development and master........the rest can stay without tests |
|
Hi @MarvinKweyu , is this still work in progress? I don't think there will be any merge conflicts because you have not touched the same files as Larry. |
|
@fatmali , you're right. I'll just update the |
|
@MarvinKweyu @DevCEldoret/backend, it's good practice to have someone review your code before it's merged in and is essential in a team setting. Merging in your own code can lead to bugs and problems that the team will have a hard time-solving. Having your code reviewed can help catch such bugs early, and enhances code quality. I have created a repository rule that we need to have at least 1 PR review and approval before code is merged , hope this will help 😃 |
|
An example of something that's missing from this PR that another person may have caught is the |
|
@fatmali , my bad on that. Addition in a few. Was trying to add the repo to the dashboard but needed the config file in the repo present |
|
Good job! |
As #14 is in review, I'll update the config file for
integration tests#11For the sake of reduced merge conflicts with the old codebase and the typescript change, this can wait, so this is still work in progress.