Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MaterialTag.directional,delay Property Modernization #2666

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

MaterialTag.directional,delay Property Modernization #2666

wants to merge 4 commits into from

Conversation

heypr
Copy link
Contributor

@heypr heypr commented Oct 31, 2024

  • Modernized MaterialTag.directional property.
  • Modernized MaterialTag.delay property.

@heypr heypr marked this pull request as draft October 31, 2024 23:40
@heypr heypr marked this pull request as ready for review December 23, 2024 00:03
mcmonkey4eva
mcmonkey4eva reviewed Dec 23, 2024
View reviewed changes
plugin/src/main/java/com/denizenscript/denizen/objects/properties/material/MaterialDelay.java Outdated
}
}
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nl@eof

mcmonkey4eva
mcmonkey4eva requested changes Dec 23, 2024
View reviewed changes
Copy link
Member

@mcmonkey4eva mcmonkey4eva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oop didn't mean to approve

@heypr heypr requested a review from mcmonkey4eva December 23, 2024 15:29
@mcmonkey4eva mcmonkey4eva changed the title Modernized Properties Part 7 MaterialTag.directional,delay Property Modernization Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmonkey4eva mcmonkey4eva mcmonkey4eva approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heypr @mcmonkey4eva