Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coverage: include tests #39

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

coverage: include tests #39

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1b8420b
coverage: include tests
blueyed Jan 20, 2019
f6d866b
improve test coverage
blueyed Feb 17, 2019
bf75085
re-raise for full coverage
blueyed Feb 17, 2019
ffa586b
fixup! improve test coverage
blueyed Feb 17, 2019
2e6512e
Revert "re-raise for full coverage"
blueyed Feb 17, 2019
8785466
fixup! fixup! improve test coverage
blueyed Feb 17, 2019
9cd4e57
tests/exceptions/nested_wrapping.py
blueyed Feb 18, 2019
1da9021
Report to codecov, with different flags for tests.
blueyed Feb 21, 2019
820e180
Add config for codecov
blueyed Mar 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/exceptions/nested_wrapping.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,6 @@ def a(x):
f(0)
except ZeroDivisionError:
logger.exception("")
raise
except Exception:
logger.exception("")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The outer exception is not covered, but tests fail with this.
I think that might indicate some missing test (i.e. you want to also test the exception being re-raised / another exception being caught in the outer block).

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the whole nested try blocks could be removed. This is not testing anything useful. Previously these test cases were generated automatically through some kind of template strings. This is no longer the case, I did not realize I could remove it.