Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverage: include tests #39

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ install:
- pip install -e .[dev]

script:
- pytest --cov loguru/
- pytest --cov

after_success:
- codecov --flags "py${TRAVIS_PYTHON_VERSION//./}"
Expand Down
1 change: 1 addition & 0 deletions tests/exceptions/nested_wrapping.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,6 @@ def a(x):
f(0)
except ZeroDivisionError:
logger.exception("")
raise
except Exception:
logger.exception("")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The outer exception is not covered, but tests fail with this.
I think that might indicate some missing test (i.e. you want to also test the exception being re-raised / another exception being caught in the outer block).

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the whole nested try blocks could be removed. This is not testing anything useful. Previously these test cases were generated automatically through some kind of template strings. This is no longer the case, I did not realize I could remove it.

4 changes: 2 additions & 2 deletions tests/test_add_options.py
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,7 @@ def test_disabled_logger_in_sink(sink_with_logger):

def test_invalid_function_kwargs():
def function(message, a="Y"):
pass
raise NotImplementedError

logger.add(function, b="X", catch=False)
with pytest.raises(TypeError):
Expand All @@ -384,7 +384,7 @@ def __init__(self):
self.out = ""

def write(self, m):
pass
raise NotImplementedError

writer = Writer()
logger.add(writer, format="{message}", kw1="1", kw2="2", catch=False)
Expand Down
3 changes: 1 addition & 2 deletions tests/test_threading.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@ def __init__(self, sleep_time):
self.stopped = False

def write(self, message):
if self.stopped:
raise RuntimeError("Can't write on stopped sink")
assert not self.stopped

length = len(message)
self.written += message[:length]
Expand Down
8 changes: 8 additions & 0 deletions tox.ini
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
[coverage:run]
source = .

[coverage:report]
include = loguru/*, tests/*
exclude_lines =
\#\s*pragma: no cover
^\s*raise NotImplementedError\b