This repository has been archived by the owner on Feb 18, 2022. It is now read-only.
Work around npm pack issue with scoped packages #47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #46
Currently, it is not possible to run
npm test @namespace/package
locally for DefinitelyTyped (see DefinitelyTyped/DefinitelyTyped#56042). The error is a bug innpm
, where it gives the incorrect filename for packed packages:Specifically, npm strips the leading
@
and removes the/
for the file it saves, but doesn't apply those changes to the filename it reports.Dts critic relies on
npm pack
's reported filename. To work around this problem, if the downloaded tarball can't be found, we do the string replacement ourselves as a backup.