Allow owners to unsubscribe from some PRs #461

fregante · 2023-04-12T06:05:09Z

Fixes Stop pinging owners over and over for the same PR (allow unsubscribing) #460

I'm sure this is incomplete, I'm just showing the suggested path forward. If accepted I can complete it.

fregante

There are probably more messages where the ping should be dropped, like StalenessComment

fregante · 2023-04-12T06:06:58Z

src/comments.ts

@@ -90,7 +90,7 @@ export const PingReviewersTooMany = (names: readonly string[]) => ({
 export const PingStaleReviewer = (reviewedAbbrOid: string, reviewers: string[]) => ({
    tag: `stale-ping-${sha256(reviewers.join("-")).substr(0, 6)}-${reviewedAbbrOid}`,
    status: txt`
-        |@${reviewers.join(", @")} Thank you for reviewing this PR! The author has pushed new
+        |**${reviewers.join(", ")}** Thank you for reviewing this PR! The author has pushed new


This is a way to mention people without actuating pinging them. It could be used anywhere.

fregante · 2023-04-12T06:07:58Z

src/comments.ts

@@ -128,7 +127,7 @@ export const RemindPeopleTheyCanUnblockPR = (user: string, approvalUsers: string
    status: txt`
        |:hourglass_flowing_sand: Hi @${user},
        |
-        |It's been a few days since this PR was approved by ${approvalUsers.join(", ")} and we're waiting for
+        |It's been a few days since this PR was approved and we're waiting for


Actually I think this was already non-pinging, so maybe this change isn't necessary

Correct, these are just usernames.

src/comments.ts

jakebailey · 2024-01-19T21:25:27Z

src/comments.ts

@@ -106,8 +106,7 @@ export const OfferSelfMerge = deletedWhenNotPresent("merge-offer", tag =>
            |> Ready to merge
            |
            |and I'll merge this PR almost instantly. Thanks for helping out! :heart:
-            |${otherOwners.length === 0 ? "" : `
-            |(${otherOwners.map(o => "@" + o).join(", ")}: you can do this too.)`}`}));
+            |${otherOwners.length === 0 ? "" : `(Any owner can do this too.)`}`}));


Instead of pinging nobody, this should probably ping those reviewers which are also owners.

After the first mention in PingReviewers, every owner is already subscribed and will receive a notification for each commit and comment.

I think this is easier to reason about if you think @user as a Subscribe @user to this PR rather than Ping @user. Do you want to subscribe them over and over?? That's the problematic part.

There should be one subscription, and then GitHub takes care of successive notifications already.

I disagree that it is "over and over" to remind everyone to actually merge the PR.

Mentions are not reminders, they're subscriptions. GitHub already reminds you after the subscription. A mention offers no improvement over no mention if you're already subscribed.

I don't fully agree. Explicit mentions are delivered to a different email address than subscriptions, a fact that some people use to filter their inboxes. Not to mention the notification page, which splits them apart:

So, I think that there is still nuance here, moreso than the simple "is or isn't subscribed". Someone could reasonably use "mentioned" as being a higher priority than "subscribed".

But, I also don't have a strong opinion. But, I also have not seen anyone complain about this whole thing outside of your linked issue either.

Please believe when I say that mentions are subscriptions.

Explicit mentions are delivered to a different email address than subscriptions

No.

Look at these two emails: one has a mention, the other is a followup notification. They have identical to/cc fields.

Further mentions or lack of mentions do no change that, unless it's a new "subscription" reason, like "assigned" or "review requested", in which case that sticks around.

Not to mention the notification page, which splits them apart

No. Same exact thing here. Once you've been mentioned, new notifications will continue to appear in the "Mentioned" filter.

… because, once again, GitHub thinks of "subscription reason", not "notification reason"

But, I also don't have a strong opinion

💙

I also have not seen anyone complain

It looks me months to find this bot. Most people will just block the repo or just asked to be removed altogether.

Heck I opened this issue in April 2023 and we're only discussing it now, which option is easier for people? 😃

No. Same exact thing here. Once you've been mentioned, new notifications will continue to appear in the "Mentioned" filter.

From one of your pings:

Then the email for the above message:

Notice no "mentioned" the second time. It's possible that the merge event behaves inconsistently.

Most people will just block the repo or just asked to be removed altogether.

That's the wrong logical direction; maybe all annoyed people remove themselves, but not all people who remove themselves do so due to pings specifically.

@jakebailey did you unsubscribe from this thread between January 19 and January 26? I just posted screenshots that show the opposite behavior, so either you unsubscribed, or the behavior isn't really reliable.

Either way the question is simple, I won't continue to debate it:

do you want to bother people who clicked Unsubscribe?

Because that's not great netiquette, also technically violating CAN-SPAM

did you unsubscribe from this thread between January 19 and January 26?

No, I did not. Thinking about it, though

To be clear, I am not against the change, but just trying to explain that there is nuance in a workflow change like this.

I'm just not really understanding the antagonism here 😞

jakebailey · 2024-01-21T19:05:43Z

Most likely you're going to need to run something like this to fix the tests, which snapshot replies to PRs.

$ AUTH_TOKEN=$(gh auth token) npm run update-all-fixtures

(But, after the comment threads are addressed, e.g. the "It's been a few days" does not to be changed)

fregante · 2024-01-27T03:40:21Z

the "It's been a few days" does not to be changed

No because that exclusively affects people who have unsubscribed, as shown in my other "review" comment.

However I think most mentions (ahem re-subscriptions) in StalenessComments are still there: https://github.com/fregante/dt-mergebot/blob/patch-1/src/comments.ts#L152

I think it's fine for now, later we can see if it's worth making further changes.

Most likely you're going to need to run something like this to fix the tests, which snapshot replies to PRs.

Snapshots updated 🫡 Tests pass locally 🟢 PR ready for merge 🚢

Thank you for still being here to discuss this with me 🙏

orta · 2024-01-27T10:17:14Z

Just to generally chime in here, I'm not wild on these changes

I think our biggest problem as DT maintainers is folks with real context not responding to these pings and removing the direct mentions in a bunch of places makes it more likely for them to be ignoring the API response. Like Jake, I have not heard people complain about this outside of the issue you reported and I'm not super convinced that we should be changing this.

fregante · 2024-01-27T11:03:47Z

@orta please read the conversation we had so far. People will still be notified. This only affects people who have clicked Unsubscribe after the first notification.

The question you have to answer when merging/discarding this PR is: do I want to send a notification to people who specifically clicked Unsubscribe on the current PR?

That's all.

fregante · 2024-04-20T13:06:55Z

It has been more than a year and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @jakebailey @sandersn @andrewbranch.

Allow owners to unsubscribe from some PRs

0c27208

fregante commented Apr 12, 2023

View reviewed changes

jakebailey reviewed Jan 19, 2024

View reviewed changes

src/comments.ts Outdated Show resolved Hide resolved

jakebailey reviewed Jan 19, 2024

View reviewed changes

Restore first ping

0475402

Update snapshots

140ec30

fregante marked this pull request as ready for review January 27, 2024 03:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow owners to unsubscribe from some PRs #461

Allow owners to unsubscribe from some PRs #461

fregante commented Apr 12, 2023

fregante left a comment

fregante Apr 12, 2023

fregante Apr 12, 2023

jakebailey Jan 19, 2024

jakebailey Jan 19, 2024

fregante Jan 20, 2024

jakebailey Jan 20, 2024

fregante Jan 20, 2024

jakebailey Jan 21, 2024

fregante Jan 27, 2024

jakebailey Jan 27, 2024

fregante Jan 27, 2024

jakebailey Jan 27, 2024

jakebailey Jan 27, 2024

jakebailey commented Jan 21, 2024

fregante commented Jan 27, 2024 •

edited

Loading

orta commented Jan 27, 2024

fregante commented Jan 27, 2024 •

edited

Loading

fregante commented Apr 20, 2024

Allow owners to unsubscribe from some PRs #461

Are you sure you want to change the base?

Allow owners to unsubscribe from some PRs #461

Conversation

fregante commented Apr 12, 2023

fregante left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jakebailey commented Jan 21, 2024

fregante commented Jan 27, 2024 • edited Loading

orta commented Jan 27, 2024

fregante commented Jan 27, 2024 • edited Loading

fregante commented Apr 20, 2024

fregante commented Jan 27, 2024 •

edited

Loading

fregante commented Jan 27, 2024 •

edited

Loading