This repository has been archived by the owner on Jul 1, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pedantic because:
mergePullRequest
comes beforeclosePullRequest
ingetMutationsForChangingPRState()
, I expect that the merge request would be honored anyway (closePullRequest
would subsequently fail, and there'd be an extraneousUnmerged:done
comment)The fix is to only perform timeline actions if the PR isn't also about to be merged.
The follow-up commit combines
shouldClose
andshouldMerge
, like #348, so it's obvious they're mutually exclusive.