Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

Don't merge and perform timeline actions #349

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jablko
Copy link
Contributor

@jablko jablko commented Jan 21, 2021

Pedantic because:

  1. It's unlikely that anyone would request to merge in the interval between the timeline expiring and the bot closing the PR
  2. Because mergePullRequest comes before closePullRequest in getMutationsForChangingPRState(), I expect that the merge request would be honored anyway (closePullRequest would subsequently fail, and there'd be an extraneous Unmerged:done comment)

The fix is to only perform timeline actions if the PR isn't also about to be merged.

The follow-up commit combines shouldClose and shouldMerge, like #348, so it's obvious they're mutually exclusive.

@elibarzilay elibarzilay force-pushed the master branch 3 times, most recently from 1d39a68 to 9e931d1 Compare July 7, 2021 15:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant