Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

Fix ping stale reviewers on subsequent reviews #293

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix ping stale reviewers on subsequent reviews #293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
424ecb9
Fix ping stale reviewers on subsequent reviews
jablko Dec 28, 2020
986ed32
Update snapshots
jablko Dec 28, 2020
54a3333
Add tests
jablko Jan 18, 2021
75440cb
New stale reviewers implies new reviewedAbbrOid
jablko Jan 6, 2021
b8021e7
Update snapshots
jablko Jan 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/_tests/fixtures/38979/_response.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1915,7 +1915,7 @@
"login": "typescript-bot",
"__typename": "User"
},
"body": "@sandersn Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-0f40f4-3aba5ac-->",
"body": "@sandersn Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-3aba5ac-->",
"createdAt": "2020-05-12T04:12:42Z",
"reactions": {
"nodes": [],
Expand All @@ -1929,7 +1929,7 @@
"login": "typescript-bot",
"__typename": "User"
},
"body": "@ljharb Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-5e6257-44403f9-->",
"body": "@ljharb Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-44403f9-->",
"createdAt": "2020-05-12T04:12:43Z",
"reactions": {
"nodes": [],
Expand All @@ -1943,7 +1943,7 @@
"login": "typescript-bot",
"__typename": "User"
},
"body": "@ljharb Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-5e6257-e40b41f-->",
"body": "@ljharb Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-e40b41f-->",
"createdAt": "2020-05-12T04:12:43Z",
"reactions": {
"nodes": [],
Expand All @@ -1957,7 +1957,7 @@
"login": "typescript-bot",
"__typename": "User"
},
"body": "@weswigham Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-9f0d93-0e6e7f4-->",
"body": "@weswigham Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-0e6e7f4-->",
"createdAt": "2020-05-12T04:12:44Z",
"reactions": {
"nodes": [],
Expand All @@ -1971,7 +1971,7 @@
"login": "typescript-bot",
"__typename": "User"
},
"body": "@ljharb Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-5e6257-efd85c4-->",
"body": "@ljharb Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-efd85c4-->",
"createdAt": "2020-05-12T04:12:45Z",
"reactions": {
"nodes": [],
Expand Down
6 changes: 3 additions & 3 deletions src/_tests/fixtures/38979/mutations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,11 @@
}
},
{
"mutation": "mutation ($input: AddCommentInput!) {\n addComment(input: $input) {\n __typename\n }\n}\n",
"mutation": "mutation ($input: UpdateIssueCommentInput!) {\n updateIssueComment(input: $input) {\n __typename\n }\n}\n",
"variables": {
"input": {
"subjectId": "MDExOlB1bGxSZXF1ZXN0MzI1ODk5Njc0",
"body": "@sandersn, @weswigham Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-764528-0e6e7f4-->"
"id": "MDEyOklzc3VlQ29tbWVudDYyNzA5NzAxNw==",
"body": "@sandersn, @weswigham Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-3aba5ac-->"
}
}
},
Expand Down
2 changes: 1 addition & 1 deletion src/_tests/fixtures/38979/result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"status": "🔔 @RReverser — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on."
},
{
"tag": "stale-ping-764528-0e6e7f4",
"tag": "stale-ping-3aba5ac",
"status": "@sandersn, @weswigham Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?"
},
{
Expand Down
2 changes: 1 addition & 1 deletion src/_tests/fixtures/43136/mutations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
"variables": {
"input": {
"subjectId": "MDExOlB1bGxSZXF1ZXN0Mzg4MzgyMzYy",
"body": "@RReverser Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-f5a3ad-37d784d-->"
"body": "@RReverser Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-37d784d-->"
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/_tests/fixtures/43136/result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"status": "🔔 @RReverser — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43136/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on."
},
{
"tag": "stale-ping-f5a3ad-37d784d",
"tag": "stale-ping-37d784d",
"status": "@RReverser Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?"
}
],
Expand Down
2 changes: 1 addition & 1 deletion src/_tests/fixtures/43175/mutations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"variables": {
"input": {
"subjectId": "MDExOlB1bGxSZXF1ZXN0Mzg5NzQ2Mjcx",
"body": "@couven92 Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-bbb366-767a750-->"
"body": "@couven92 Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-767a750-->"
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/_tests/fixtures/43175/result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"status": "🔔 @matthewkimber @otiai10 @couven92 @rreverser @sreimer15 @MatCarlson @ekinsol @tregagnon @echoabstract @spasma — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43175/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on."
},
{
"tag": "stale-ping-bbb366-767a750",
"tag": "stale-ping-767a750",
"status": "@couven92 Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?"
}
],
Expand Down
4 changes: 2 additions & 2 deletions src/_tests/fixtures/43695-duplicate-comment/_response.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -996,7 +996,7 @@
"login": "typescript-bot",
"__typename": "User"
},
"body": "@RyanCavanaugh Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-fbf110-a5285cd-->",
"body": "@RyanCavanaugh Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-a5285cd-->",
"createdAt": "2020-04-15T16:26:50Z",
"reactions": {
"nodes": [],
Expand All @@ -1010,7 +1010,7 @@
"login": "typescript-bot",
"__typename": "User"
},
"body": "@RyanCavanaugh Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-fbf110-a5285cd-->",
"body": "@RyanCavanaugh Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-a5285cd-->",
"createdAt": "2020-04-15T16:26:50Z",
"reactions": {
"nodes": [],
Expand Down
2 changes: 1 addition & 1 deletion src/_tests/fixtures/43695-duplicate-comment/mutations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
"variables": {
"input": {
"subjectId": "MDExOlB1bGxSZXF1ZXN0NDAwMTAwMTk2",
"body": "@andrewbranch, @RyanCavanaugh Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-61f252-a5285cd-->"
"body": "@andrewbranch, @RyanCavanaugh Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-68463fd-->"
}
}
},
Expand Down
2 changes: 1 addition & 1 deletion src/_tests/fixtures/43695-duplicate-comment/result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"status": "🔔 @alexandercerutti — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43695/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)"
},
{
"tag": "stale-ping-61f252-a5285cd",
"tag": "stale-ping-68463fd",
"status": "@andrewbranch, @RyanCavanaugh Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?"
},
{
Expand Down
4 changes: 2 additions & 2 deletions src/_tests/fixtures/43695-post-review/_response.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,7 +649,7 @@
"login": "typescript-bot",
"__typename": "User"
},
"body": "@RyanCavanaugh Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-fbf110-a5285cd-->",
"body": "@RyanCavanaugh Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-a5285cd-->",
"createdAt": "2020-04-15T16:26:50Z",
"reactions": {
"nodes": [],
Expand All @@ -663,7 +663,7 @@
"login": "typescript-bot",
"__typename": "User"
},
"body": "@RyanCavanaugh Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-fbf110-a5285cd-->",
"body": "@RyanCavanaugh Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-a5285cd-->",
"createdAt": "2020-04-15T16:26:50Z",
"reactions": {
"nodes": [],
Expand Down
2 changes: 1 addition & 1 deletion src/_tests/fixtures/44256/_response.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,7 +448,7 @@
"login": "typescript-bot",
"__typename": "User"
},
"body": "@marcobeltempo Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-bf970f-ab5d8bc-->",
"body": "@marcobeltempo Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-ab5d8bc-->",
"createdAt": "2020-04-30T00:59:09Z",
"reactions": {
"nodes": [],
Expand Down
2 changes: 1 addition & 1 deletion src/_tests/fixtures/44857/_response.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -757,7 +757,7 @@
"login": "typescript-bot",
"__typename": "User"
},
"body": "@SimonSchick Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-37410c-b0cfd18-->",
"body": "@SimonSchick Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-b0cfd18-->",
"createdAt": "2020-05-21T11:57:32Z",
"reactions": {
"nodes": [],
Expand Down
2 changes: 1 addition & 1 deletion src/_tests/fixtures/44857/result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"status": "🔔 @Microsoft @DefinitelyTyped @jkomyno @a-tarasyuk @alvis @r3nya @btoueg @brunoscheufler @smac89 @touffy @DeividasBakanas @eyqs @Flarna @Hannes-Magnusson-CK @KSXGitHub @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @n-e @galkin @parambirs @eps1lon @SimonSchick @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @j-oliveras @bhongy @chyzwar @trivikr @nguymin4 @yoursunny @qwelias @Ryan-Willpower @peterblazejewicz @addaleax @JasonHK — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44857/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on."
},
{
"tag": "stale-ping-37410c-b0cfd18",
"tag": "stale-ping-b0cfd18",
"status": "@SimonSchick Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?"
},
{
Expand Down
2 changes: 1 addition & 1 deletion src/_tests/fixtures/45890/_response.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@
"login": "typescript-bot",
"__typename": "User"
},
"body": "@peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-ef7ed8-5e68fad-->",
"body": "@peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-5e68fad-->",
"createdAt": "2020-07-04T22:05:17Z",
"reactions": {
"nodes": [],
Expand Down
2 changes: 1 addition & 1 deletion src/_tests/fixtures/45999/_response.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@
"login": "typescript-bot",
"__typename": "User"
},
"body": "@eps1lon Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-2d81fa-eb19530-->",
"body": "@eps1lon Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-eb19530-->",
"createdAt": "2020-07-10T13:31:50Z",
"reactions": {
"nodes": [],
Expand Down
2 changes: 1 addition & 1 deletion src/_tests/fixtures/46120/_response.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2078,7 +2078,7 @@
"login": "typescript-bot",
"__typename": "User"
},
"body": "@jgonggrijp Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-f6fb8c-7fbaab6-->",
"body": "@jgonggrijp Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-7fbaab6-->",
"createdAt": "2020-07-17T05:47:20Z",
"reactions": {
"nodes": [],
Expand Down
4 changes: 2 additions & 2 deletions src/_tests/fixtures/48652-merge-offer/_response.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,7 +639,7 @@
"login": "typescript-bot",
"__typename": "User"
},
"body": "@peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-ef7ed8-753cdb3-->",
"body": "@peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-753cdb3-->",
"createdAt": "2020-10-13T08:30:42Z",
"reactions": {
"nodes": [],
Expand Down Expand Up @@ -717,7 +717,7 @@
"login": "typescript-bot",
"__typename": "User"
},
"body": "@thorn0, @falsyvalues Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-726cfd-753cdb3-->",
"body": "@thorn0, @falsyvalues Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-753cdb3-->",
"createdAt": "2020-11-03T02:25:17Z",
"reactions": {
"nodes": [],
Expand Down
2 changes: 1 addition & 1 deletion src/_tests/fixtures/48652-merge-offer/mutations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"variables": {
"input": {
"subjectId": "MDExOlB1bGxSZXF1ZXN0NTAwNjg4ODM0",
"body": "@RyanCavanaugh, @thorn0, @falsyvalues Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-024242-753cdb3-->"
"body": "@RyanCavanaugh, @thorn0, @falsyvalues Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-fa21531-->"
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/_tests/fixtures/48652-merge-offer/result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"status": "@mgol Everything looks good here. Great job! I am ready to merge this PR (at 06d8d67) on your behalf.\n\nIf you'd like that to happen, please post a comment saying:\n\n> Ready to merge\n\nand I'll merge this PR almost instantly. Thanks for helping out! :heart:\n"
},
{
"tag": "stale-ping-024242-753cdb3",
"tag": "stale-ping-fa21531",
"status": "@RyanCavanaugh, @thorn0, @falsyvalues Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?"
}
],
Expand Down
4 changes: 2 additions & 2 deletions src/_tests/fixtures/48652-prereq/_response.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,7 +639,7 @@
"login": "typescript-bot",
"__typename": "User"
},
"body": "@peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-ef7ed8-753cdb3-->",
"body": "@peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-753cdb3-->",
"createdAt": "2020-10-13T08:30:42Z",
"reactions": {
"nodes": [],
Expand Down Expand Up @@ -717,7 +717,7 @@
"login": "typescript-bot",
"__typename": "User"
},
"body": "@thorn0, @falsyvalues Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-726cfd-753cdb3-->",
"body": "@thorn0, @falsyvalues Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-753cdb3-->",
"createdAt": "2020-11-03T02:25:17Z",
"reactions": {
"nodes": [],
Expand Down
Loading