-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color-code Nebula and regular IPs #141
base: main
Are you sure you want to change the base?
Conversation
jasikpark
commented
Jun 7, 2024
- Start color coding overlay and underlay ips
- More color coding
- Even more color coded overlay/underlay ip addresses
✅ Deploy Preview for nebula-docs-dn ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I'm not 100% sure about using underlines here, it makes them look like links to me. And the color difference is pretty subtle / easy to miss. I'd want to have @bgolat take a look and give his take, at least. Brian, a good page to look at might be https://deploy-preview-141--nebula-docs-dn.netlify.app/docs/config/lighthouse/. |
The styles are 100% up for debate, I just wanted to get something semi-reasonable up |
8b5923e
to
1b1b9d3
Compare
What is the context of this? I would avoid underlining text as a way to highlight since that it generally reserved for links. |
Highlighting would probably be preferred then; the goal is to indicate when an IP or address refers to a Nebula overlay IP or an underlay IP from the regular network. |