Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color-code Nebula and regular IPs #141

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jasikpark
Copy link
Collaborator

  • Start color coding overlay and underlay ips
  • More color coding
  • Even more color coded overlay/underlay ip addresses

Copy link

netlify bot commented Jun 7, 2024

Deploy Preview for nebula-docs-dn ready!

Name Link
🔨 Latest commit 22f6b53
🔍 Latest deploy log https://app.netlify.com/sites/nebula-docs-dn/deploys/66686172816563000869fc7b
😎 Deploy Preview https://deploy-preview-141--nebula-docs-dn.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@IanVS
Copy link
Collaborator

IanVS commented Jun 11, 2024

I'm not 100% sure about using underlines here, it makes them look like links to me. And the color difference is pretty subtle / easy to miss. I'd want to have @bgolat take a look and give his take, at least. Brian, a good page to look at might be https://deploy-preview-141--nebula-docs-dn.netlify.app/docs/config/lighthouse/.

@IanVS IanVS requested a review from bgolat June 11, 2024 12:32
@jasikpark
Copy link
Collaborator Author

The styles are 100% up for debate, I just wanted to get something semi-reasonable up

@jasikpark jasikpark force-pushed the color-code-nebula-and-regular-ip branch from 8b5923e to 1b1b9d3 Compare June 11, 2024 14:38
@bgolat
Copy link
Contributor

bgolat commented Jun 12, 2024

What is the context of this? I would avoid underlining text as a way to highlight since that it generally reserved for links.

@jasikpark
Copy link
Collaborator Author

Highlighting would probably be preferred then; the goal is to indicate when an IP or address refers to a Nebula overlay IP or an underlay IP from the regular network.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants