-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maverick-v2 yields #1565
base: master
Are you sure you want to change the base?
maverick-v2 yields #1565
Conversation
The maverick-v2 adapter exports pools: Test Suites: 1 passed, 1 total
|
The maverick-v2 adapter exports pools: Test Suites: 1 passed, 1 total
|
The maverick-v2 adapter exports pools: Test Suites: 1 passed, 1 total
|
The maverick-v2 adapter exports pools: Test Suites: 1 passed, 1 total
|
gm,
|
hi @slasher125, thanks; I will fix the symbols. not sure what you mean about on chain calls. there are no on chain calls here. the mav api that is called is a thin wrapper on a subgraph. i was following the convention in the |
The maverick-v2 adapter exports pools: Test Suites: 1 passed, 1 total
|
what i meant is to refactor the code using our sdk instead of fetching from our api (see readme) |
@slasher125 sorry, i still dont understand. I am using Please do let me know more specifically which part of the code is not using the SDK in the way that it should and I will fix it. thanks! |
i'm referring to the defillama sdk https://www.npmjs.com/package/@defillama/sdk which we use across our server repos using this (there are tons of examples in this repo alone) makes the adapter much more robust vs relying on the api + makes it transparent how apy values are being calculated. |
so you are saying i cant use the convention in the readme and just hit an api and instead have to reconstruct the apy from scratch using blockchain calls? |
yes; there is more info here: https://github.com/DefiLlama/yield-server?tab=readme-ov-file#data-sources |
No description provided.