Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bug#1448: made VtmnSelect React component to show label only when labelText prop is passed to it #1495

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rajeshpoojari39
Copy link

Changes description

Made changes to VtmnSelect React component to show label only when labelText prop is passed to it.

Context

The issue mentioned in the below link says the VtmnSelect component shows label html tag when empty label is passed to the component. I have made fix for this in the VtmnSelect React component only, as I am well versed with react. With this fix the component will not add empty label html tag if labelText prop is not passed to it.
#1448

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.
  • I have tested on related showcases.
  • If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

Does this introduce a breaking change?

  • No

Other information

This issue is only fixed for VtmnSelect React component

@rajeshpoojari39 rajeshpoojari39 requested review from thibault-mahe and a team as code owners July 6, 2024 08:16
@CLAassistant
Copy link

CLAassistant commented Jul 6, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants