Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@vtmn/css): enhancement VtmnSelect make the props label optional #1448

Open
Mig-l opened this issue Jun 23, 2023 · 1 comment
Open

feat(@vtmn/css): enhancement VtmnSelect make the props label optional #1448

Mig-l opened this issue Jun 23, 2023 · 1 comment
Labels
bug 🐛 Something isn't working community 👥 As we stopped improvements for this version of Vitamin, this issue needs to be done by the community CSS 🎨 Related to CSS styles packages

Comments

@Mig-l
Copy link
Contributor

Mig-l commented Jun 23, 2023

Describe the bug

image

We need to use the VtmnSelect without the label.
The label props is mandatory

image

If we pass the label props with an empty string, we still have an HTML label tag that is generated but empty.

image

Steps to reproduce

https://decathlon.github.io/vitamin-web/@vtmn/showcase-svelte/?path=/story/components-forms-vtmnselect--overview

Expected behavior

We have in production a select without label for the choice of the language that we must switch to Vitamin

image

We will want to use the VtmnSelect without the label

@Mig-l Mig-l added the bug 🐛 Something isn't working label Jun 23, 2023
@lauthieb lauthieb added the community 👥 As we stopped improvements for this version of Vitamin, this issue needs to be done by the community label Jun 23, 2023
@lauthieb lauthieb added the CSS 🎨 Related to CSS styles packages label Jul 3, 2023
@lauthieb lauthieb changed the title feat: enhancement VtmnSelect make the props label optional feat(@vtmn/css): enhancement VtmnSelect make the props label optional Jul 3, 2023
@lauthieb lauthieb moved this from 🆕 New to 🔖 Dev to do in Decathlon Design System Jul 3, 2023
@stale
Copy link

stale bot commented Aug 31, 2023

This has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reopen whenever you want. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working community 👥 As we stopped improvements for this version of Vitamin, this issue needs to be done by the community CSS 🎨 Related to CSS styles packages
Projects
Status: 🔖 Dev to do
Development

No branches or pull requests

2 participants