Fixed constructor retrieval when using ES6 proxies#98
Open
maicol07 wants to merge 2 commits intoDavidDuwaer:masterfrom
Open
Fixed constructor retrieval when using ES6 proxies#98maicol07 wants to merge 2 commits intoDavidDuwaer:masterfrom
maicol07 wants to merge 2 commits intoDavidDuwaer:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same issue as #88, although this time is a bit deeper.
I've added two private methods to get the constructor of the current model or the one of another instance, different than the current one. This way it will be easier to get the constructor and also reduce repetitions