-
Notifications
You must be signed in to change notification settings - Fork 4
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #35 from DaveLiddament/fix/samples-for-test-tags
FIX example code for TestTag on a class
- Loading branch information
Showing
8 changed files
with
165 additions
and
83 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
<?php | ||
|
||
namespace TestTagClassOnConstructor; | ||
|
||
use DaveLiddament\PhpLanguageExtensions\TestTag; | ||
|
||
#[TestTag] | ||
class Person | ||
{ | ||
public function __construct() | ||
{ | ||
} | ||
|
||
public static function create(): Person | ||
{ | ||
return new Person(); // OK - whole class is marked with TestTag, so OK to call methods within it. | ||
} | ||
|
||
public static function createSelf(): self | ||
{ | ||
return new self(); // OK - whole class is marked with TestTag, so OK to call methods within it. | ||
} | ||
} | ||
|
||
class AnotherClass | ||
{ | ||
public function buildPerson(): Person | ||
{ | ||
return new Person(); // ERROR | ||
} | ||
} |
21 changes: 21 additions & 0 deletions
21
examples/testTag/testTagClassOnConstructorIgnoredInTestClass.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
<?php | ||
|
||
namespace TestTagClassOnConstructorIgnoredInTestClass; | ||
|
||
use DaveLiddament\PhpLanguageExtensions\TestTag; | ||
|
||
#[TestTag] | ||
class Person | ||
{ | ||
public function __construct() | ||
{ | ||
} | ||
} | ||
|
||
class PersonTest | ||
{ | ||
public function buildPerson(): Person | ||
{ | ||
return new Person(); // OK TetTag called from a test class | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
namespace TestTagClassOnMethod; | ||
|
||
use DaveLiddament\PhpLanguageExtensions\TestTag; | ||
|
||
#[TestTag] | ||
class Person | ||
{ | ||
public function updateName(): void | ||
{ | ||
} | ||
|
||
public function update(): void | ||
{ | ||
$this->updateName(); // OK - whole class is marked with TestTag, so OK to call methods within it. | ||
} | ||
} | ||
|
||
class Updater | ||
{ | ||
public function updater(Person $person): void | ||
{ | ||
$person->updateName(); // ERROR | ||
} | ||
} | ||
|
||
$person = new Person(); | ||
$person->updateName(); // ERROR | ||
|
25 changes: 25 additions & 0 deletions
25
examples/testTag/testTagClassOnMethodIgnoredInTestClass.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
namespace TestTagClassOnMethodIgnoredInTestClass; | ||
|
||
use DaveLiddament\PhpLanguageExtensions\TestTag; | ||
|
||
#[TestTag] | ||
class Person | ||
{ | ||
public function updateName(): void | ||
{ | ||
} | ||
} | ||
|
||
class PersonTest | ||
{ | ||
public function updater(Person $person): void | ||
{ | ||
$person->updateName(); // OK - Called from Test class | ||
} | ||
} | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
<?php | ||
|
||
namespace TestTagClassOnStaticMethod; | ||
|
||
|
||
use DaveLiddament\PhpLanguageExtensions\TestTag; | ||
|
||
#[TestTag] | ||
class Person | ||
{ | ||
public static function updateName(): void | ||
{ | ||
} | ||
|
||
public static function update(): void | ||
{ | ||
Person::updateName(); // OK - whole class is marked with TestTag, so OK to call methods within it. | ||
} | ||
|
||
public static function updateSelf(): void | ||
{ | ||
self::updateName(); // OK - whole class is marked with TestTag, so OK to call methods within it. | ||
} | ||
} | ||
|
||
class Updater | ||
{ | ||
public function updater(): void | ||
{ | ||
Person::updateName(); // ERROR | ||
} | ||
} | ||
|
||
Person::updateName(); // ERROR |
22 changes: 22 additions & 0 deletions
22
examples/testTag/testTagClassOnStaticMethodIgnoredInTestClass.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
<?php | ||
|
||
namespace TestTagClassOnStaticMethodIgnoredInTestClass; | ||
|
||
|
||
use DaveLiddament\PhpLanguageExtensions\TestTag; | ||
|
||
#[TestTag] | ||
class Person | ||
{ | ||
public static function updateName(): void | ||
{ | ||
} | ||
} | ||
|
||
class PersonTest | ||
{ | ||
public function updater(): void | ||
{ | ||
Person::updateName(); // OK - Called from a test class | ||
} | ||
} |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.