fix multiline read from yaml; do not crash on filtering where no fail…

…s are present

DESCRIPTION

@@ -1,7 +1,7 @@
 Package: dataverifyr
 Type: Package
 Title: A Lightweight, Flexible, and Fast Data Validation Package that Can Handle All Sizes of Data
-Version: 0.1.6
+Version: 0.1.6.9001
 Authors@R: c(
       person(given = "David",
              family = "Zimmermann-Kollenda",

NEWS.md

@@ -1,7 +1,8 @@
 # dataverifyr 0.1.6
 
+* allow multiline rules in yaml file
+* fix bug where no fails in filter_fails would result in error
 * Fix bug where multiline rules would break
-
 * fix minor error in Readme
 * `filter_fails()` allows the first argument to be a `ruleset` and not only a result of `check_data()`
 

R/filters.R

@@ -44,6 +44,8 @@ filter_fails <- function(res, x, per_rule = FALSE) {
     negated <- res$negate[fails]
     allow_na <- res$allow_na[fails]
 
+    if (all(!fails)) return(x[0, ])
+
   }
 
   type <- detect_type(class(x))

R/im-export.R

@@ -37,6 +37,7 @@ read_rules <- function(file) {
   }
 
   res <- lapply(res, function(r) {
+    r$expr <- paste(r$expr, collapse = "\n")
     class(r) <- "rule"
     r
   })

tests/testthat/test-filters.R

@@ -37,3 +37,23 @@ test_that("filters return values that are not matched by the rules", {
   fails2 <- filter_fails(rules, data, per_rule = TRUE)
   expect_equal(fails2, fails)
 })
+
+test_that("No fails do not crash", {
+  data <- mtcars
+
+  rules <- ruleset(
+    rule(mpg > 10 & mpg < 35),
+    rule(cyl != 5),
+    rule(vs %in% c(0, 1))
+  )
+
+  res <- check_data(data, rules)
+  rr <- filter_fails(res, data)
+  expect_equal(nrow(rr), 0)
+  expect_equal(names(rr), names(data))
+
+  # also works when ruleset is provided
+  rr2 <- filter_fails(rules, data)
+  expect_equal(nrow(rr2), 0)
+  expect_equal(names(rr2), names(data))
+})