feat: update choropleth map, add color scale options, add tick toggle…

…, refactor, ruff fixes

ckanext/charts/cache.py

@@ -36,7 +36,6 @@ def get_data(self, key: str) -> pd.DataFrame | None:
         Returns:
             The data if exists, otherwise None.
         """
-        pass
 
     @abstractmethod
     def set_data(self, key: str, data: pd.DataFrame):
@@ -46,7 +45,6 @@ def set_data(self, key: str, data: pd.DataFrame):
             key: The cache key to store the data.
             data: The data to be stored.
         """
-        pass
 
     @abstractmethod
     def invalidate(self, key: str) -> None:
@@ -55,7 +53,6 @@ def invalidate(self, key: str) -> None:
         Args:
             key: The cache key to invalidate.
         """
-        pass
 
 
 class RedisCache(CacheStrategy):
@@ -151,7 +148,6 @@ def read_data(self, file: IO) -> pd.DataFrame | None:
         Returns:
             The data if exists, otherwise None.
         """
-        pass
 
     def set_data(self, key: str, data: pd.DataFrame) -> None:
         """Store data to cache.
@@ -172,7 +168,6 @@ def write_data(self, file_path: str, data: pd.DataFrame) -> None:
             file_path: The path to the file.
             data: The data to be stored.
         """
-        pass
 
     def invalidate(self, key: str) -> None:
         """Remove data from cache.

ckanext/charts/chart_builders/base.py

@@ -195,7 +195,7 @@ class BaseChartForm(ABC):
     name = ""
 
     def __init__(
-        self, resource_id: str | None = None, dataframe: pd.DataFrame | None = None
+        self, resource_id: str | None = None, dataframe: pd.DataFrame | None = None,
     ) -> None:
         if dataframe is not None:
             self.df = dataframe
@@ -279,7 +279,7 @@ def get_validation_schema(self, for_show: bool = False) -> dict[str, Any]:
                 if "validators" in field
             }
         except KeyError:
-            raise ChartBuildError("Form field missing 'field_name' key")
+            raise ChartBuildError("Form field missing 'field_name' key") from None
 
         return validation_schema
 
@@ -546,6 +546,7 @@ def split_data_field(self) -> dict[str, Any]:
             "form_snippet": "chart_checkbox.html",
             "group": "Data",
             "validators": [
+                self.get_validator("chart_checkbox"),
                 self.get_validator("default")(False),
                 self.get_validator("boolean_validator"),
             ],
@@ -564,6 +565,8 @@ def skip_null_values_field(self) -> dict[str, Any]:
             "form_snippet": "chart_checkbox.html",
             "group": "Data",
             "validators": [
+                self.get_validator("chart_checkbox"),
+                self.get_validator("default")(False),
                 self.get_validator("boolean_validator"),
             ],
             "help_text": """Entries of the data with missing values will not be
@@ -578,6 +581,8 @@ def break_chart_field(self) -> dict[str, Any]:
             "form_snippet": "chart_checkbox.html",
             "group": "Data",
             "validators": [
+                self.get_validator("chart_checkbox"),
+                self.get_validator("default")(False),
                 self.get_validator("boolean_validator"),
             ],
             "help_text": "Break the graph at missing values",
@@ -591,6 +596,7 @@ def sort_x_field(self) -> dict[str, Any]:
             "form_snippet": "chart_checkbox.html",
             "group": "Data",
             "validators": [
+                self.get_validator("chart_checkbox"),
                 self.get_validator("default")(False),
                 self.get_validator("boolean_validator"),
             ],
@@ -606,6 +612,7 @@ def sort_y_field(self) -> dict[str, Any]:
             "form_snippet": "chart_checkbox.html",
             "group": "Data",
             "validators": [
+                self.get_validator("chart_checkbox"),
                 self.get_validator("default")(False),
                 self.get_validator("boolean_validator"),
             ],
@@ -621,6 +628,7 @@ def invert_x_field(self) -> dict[str, Any]:
             "form_snippet": "chart_checkbox.html",
             "group": "Data",
             "validators": [
+                self.get_validator("chart_checkbox"),
                 self.get_validator("default")(False),
                 self.get_validator("boolean_validator"),
             ],
@@ -636,6 +644,7 @@ def invert_y_field(self) -> dict[str, Any]:
             "form_snippet": "chart_checkbox.html",
             "group": "Data",
             "validators": [
+                self.get_validator("chart_checkbox"),
                 self.get_validator("default")(False),
                 self.get_validator("boolean_validator"),
             ],
@@ -651,6 +660,7 @@ def log_x_field(self) -> dict[str, Any]:
             "form_snippet": "chart_checkbox.html",
             "group": "Data",
             "validators": [
+                self.get_validator("chart_checkbox"),
                 self.get_validator("default")(False),
                 self.get_validator("boolean_validator"),
             ],
@@ -666,6 +676,7 @@ def log_y_field(self) -> dict[str, Any]:
             "form_snippet": "chart_checkbox.html",
             "group": "Data",
             "validators": [
+                self.get_validator("chart_checkbox"),
                 self.get_validator("default")(False),
                 self.get_validator("boolean_validator"),
             ],
@@ -720,7 +731,7 @@ def opacity_field(self) -> dict[str, Any]:
             "default": 1,
         }
 
-    def limit_field(self, default: int = 100, maximum: int = 10000) -> dict[str, Any]:
+    def limit_field(self, default: int = 1000, maximum: int = 10000) -> dict[str, Any]:
         """The limit field represent an amount of rows to show in the chart."""
         return {
             "field_name": "limit",

ckanext/charts/chart_builders/chartjs.py

@@ -363,7 +363,7 @@ def to_json(self) -> str:
         try:
             dates = pd.to_datetime(self.df[self.settings["x"]], unit="ns")
             self.settings["years"] = list(
-                dates.dt.strftime(self.YEAR_DATETIME_FORMAT).unique()
+                dates.dt.strftime(self.YEAR_DATETIME_FORMAT).unique(),
             )
         except (ParserError, ValueError):
             self.settings["years"] = []

ckanext/charts/chart_builders/observable.py

@@ -4,7 +4,6 @@
 import pandas as pd
 from typing import Any
 
-from ckanext.charts import exception
 from ckanext.charts.chart_builders.base import BaseChartBuilder, BaseChartForm