Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test profiling scenarios on the same set of VMs we use for tracing ones #3873

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

szegedi
Copy link
Contributor

@szegedi szegedi commented Jan 22, 2025

Test profiling scenarios on the same set of VMs we use for tracing equivalent tracing scenarios

Motivation

Better coverage of profiling scenarios, now that we're gearing for Profiling+SSI GA. We even had some ridiculous anomalies, such as Node.js and Java CONTAINER_AUTO_INJECTION_INSTALL_SCRIPT_PROFILING scenarios executing nothing as the Node.js and Java weblogs only run on Ubuntu 24 and it was excluded from the profiling by default.

Changes

InstallerAutoInjectionScenarioProfiling, the scenario class with a restricted list of VMs is retired and the various *_profiling scenarios are now instantiated as ordinary InstallerAutoInjectionScenario instead with the full set of VMs used for tracing scenarios too.

JIRA: PROF-11177

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@szegedi szegedi force-pushed the szegedi/profiler-tests-everywhere branch from 8685dbb to 7d91bcf Compare January 22, 2025 14:10
Copy link
Collaborator

@robertomonteromiguel robertomonteromiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants