Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apm standalone shared tests #3829

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Jan 15, 2025

Motivation

Make sure that ASM Standalone plays nicely with other propagation style headers than default.

Especially with SSI.

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

trace = test_agent.wait_for_num_traces(2)
span = find_span_in_traces(trace, s1.trace_id, s1.span_id)
span["name"] = "identical_trace_info"
assert span["metrics"].get(SAMPLING_PRIORITY_KEY) == -1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nodejs tracer is using AUTO_REJECT (0) in that case.

Could we change the tests asserts to assert span["metrics"].get(SAMPLING_PRIORITY_KEY) <= 0?

Or the nodejs is wrong and that priority value is mandatory?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants