Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nit: Fix spelling of Node.js and .NET #3786

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

watson
Copy link
Contributor

@watson watson commented Jan 9, 2025

Motivation

This isn't that important. But it's a signal about how we treat the two communities. By spelling the name of their language incorrectly, it could be interpreted as not caring/respecting, which obviously we do.

Changes

  • Any purmutation of dotNet is now spelled .NET
  • Any purmutation of NodeJs is now spelled Node.js.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

Copy link
Contributor Author

watson commented Jan 9, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@watson watson marked this pull request as ready for review January 9, 2025 09:24
@watson watson requested review from mabdinur and a team as code owners January 9, 2025 09:24
@simon-id
Copy link
Member

simon-id commented Jan 9, 2025

You know people still have to use nodejs and dotnet in the test files, the test versions definitions, the CLI, etc etc
Maybe, just maybe, having them misspelled in these place, can avoid confusion when trying to use the internal values?

Copy link
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No opinion here, as long as each guild is fine with the change, I'm ok!

@watson watson requested a review from simon-id January 9, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants