[Tracing] Add test and endpoints to test OTEL Drop-In Support of the OpenTelemetry Propagators API #3782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacharycmontoya
force-pushed
the
zach.montoya/otel-default-propagation
branch
from
739e2cc to
c72e7d9
Compare
…for injecting / extracting context
…implemented in the .NET Tracer itself to overwrite the default propagator
…G_E2E_OTEL scenario
…run automatic instrumentation in the typical dd-trace-go setup, so the user is expected to set the default propagator. This test simply tests that using the API `otel.GetTextMapPropagator()` works as expected
…fault inject is successful.
zacharycmontoya
force-pushed
the
zach.montoya/otel-default-propagation
branch
from
247982b to
0498f59
Compare
zacharycmontoya
requested review from
P403n1x87,
wantsui,
Mariovido,
sezen-datadog,
mcculls and
dmehala
and removed request for
a team
cbeauchesne
approved these changes
Jan 28, 2025
…emented)" to reflect that the functionality should be there, but not all weblog applications have implemented the endpoint
|
Just do double check: the functionality you're trying to test is that when the OpenTelemetry SDK is removed and users are relying on drop-in support, the propagator APIs work as usual without having to enable anything? |
Yes exactly! And more specifically, I'm testing the case where the user gets the default propagator provided by the language's OpenTelemetry API, without the user configuring their own. |
cbeauchesne
approved these changes
Jan 29, 2025
link04
approved these changes
Jan 29, 2025
rachelyangdog
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We learned that there was an issue with this support in the .NET tracing library, so this new test/endpoint will identify whether other tracers have the same class of issue.
In the .NET scenario, the customer can use the OpenTelemetry Propagators API (implemented in the OpenTelemetry API package) to manually propagate context. When the OpenTelemetry SDK is configured (using the OpenTelemetry SDK package) in the application, the default propagator provided by the OpenTelemetry Propagators API is provided a default implementation, so propagation works as expected. However, when the OpenTelemetry SDK is removed and the user relies on the .NET tracer's OTEL Drop-In Support, the default propagator provided by the OpenTelemetry Propagators API is a no-op, resulting in no propagation happening.
Changes
/otel_drop_in_default_propagator_extract/otel_drop_in_default_propagator_injectTest_Otel_Context_Propagation_Default_Propagator_Apiwith test cases:test_propagation_extracttest_propagation_injectWorkflow
codeownersfile quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present