Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP] Enable SSRF tests #3769

Merged
merged 3 commits into from
Jan 31, 2025
Merged

[PHP] Enable SSRF tests #3769

merged 3 commits into from
Jan 31, 2025

Conversation

estringana
Copy link
Contributor

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@estringana estringana force-pushed the estringana/enable-ssrf-for-php branch from f74db52 to b027b9e Compare January 7, 2025 09:33
@estringana estringana force-pushed the estringana/enable-ssrf-for-php branch 2 times, most recently from 833b5ae to e772dfa Compare January 30, 2025 10:16
@estringana estringana force-pushed the estringana/enable-ssrf-for-php branch from e772dfa to 14a62c8 Compare January 30, 2025 10:16
@estringana estringana marked this pull request as ready for review January 30, 2025 12:24
@estringana estringana requested review from a team as code owners January 30, 2025 12:24
@robertpi
Copy link
Member

Just noticed the CI is failing, but it's in a python run, so presumably flake.

@cbeauchesne cbeauchesne changed the title Enable SSRF tests for PHP [PHP] Enable SSRF tests Jan 30, 2025
@estringana estringana merged commit c112a3c into main Jan 31, 2025
462 of 512 checks passed
@estringana estringana deleted the estringana/enable-ssrf-for-php branch January 31, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants