Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet] parametric app improvements #3723

Draft
wants to merge 38 commits into
base: main
Choose a base branch
from

Conversation

lucaspimentel
Copy link
Member

@lucaspimentel lucaspimentel commented Dec 19, 2024

Motivation

Improve the experience of modifying, running, and troubleshooting the parametric app for dotnet.

Changes

  • nuget packages (TODO: move this into a separate PR?)
    • pick up local nuget packages dropped in utils/build/docker/dotnet/parametric/ (TODO: support binaries/)
    • prioritize local packages over the nuget.org feed
  • JSON serialization
    • use the built-in System.Text.Json, remove dependency on Newtonsoft.Json
    • de-deduplicate code into helper methods, add shared validation and logging
  • small reflection refactoring to reduce repetition
  • enable more built-in logging by default
  • misc code clean-up to reduce compiler warnings
    • add missing nullability annotations and null checks
    • make members private where possible

Sidenote: while making these changes I found several unrelated bugs when using the .NET tracing library's manual API

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@lucaspimentel lucaspimentel force-pushed the lpimentel/dotnet-json-helper branch 3 times, most recently from 223303e to f296fa8 Compare December 19, 2024 03:57
@lucaspimentel lucaspimentel added dev-x Improve developer experience dotnet Pull requests that update .NET code run-parametric-scenario labels Dec 19, 2024
@lucaspimentel lucaspimentel force-pushed the lpimentel/dotnet-json-helper branch 3 times, most recently from 0359852 to 6d900c3 Compare December 19, 2024 06:19
@lucaspimentel lucaspimentel force-pushed the lpimentel/dotnet-json-helper branch from 6173f48 to 0d884a9 Compare December 19, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-x Improve developer experience dotnet Pull requests that update .NET code run-parametric-scenario
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant