-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Debugger] Re-enable Node.js tests that should now be working #3582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Nov 28, 2024
watson
force-pushed
the
watson/fix-nodejs-bugs
branch
from
December 3, 2024 12:47
4651c33
to
0f6ffb3
Compare
watson
force-pushed
the
watson/probe-has-version
branch
from
December 12, 2024 19:34
9a29d68
to
9f8b315
Compare
watson
force-pushed
the
watson/fix-nodejs-bugs
branch
from
January 7, 2025 08:36
0f6ffb3
to
6e6fe11
Compare
watson
changed the base branch from
main
to
watson/12-17-_debugger_ensure_all_probes_have_a_version_property
January 7, 2025 08:36
7 tasks
watson
changed the title
[Debugger] Fix diagnostics schema
[Debugger] Re-enable Node.js tests that should now be working
Jan 7, 2025
Base automatically changed from
watson/12-17-_debugger_ensure_all_probes_have_a_version_property
to
main
January 7, 2025 09:41
watson
force-pushed
the
watson/fix-nodejs-bugs
branch
from
January 7, 2025 09:54
6e6fe11
to
3f61ff5
Compare
watson
force-pushed
the
watson/fix-nodejs-bugs
branch
from
January 8, 2025 08:46
3f61ff5
to
5c1f430
Compare
cbeauchesne
reviewed
Jan 9, 2025
- The root `message` property is not expected. - The probe version should be encoded in a `version` property - not a `probeVersion` property.
This reverts commit 5c1f430.
watson
force-pushed
the
watson/fix-nodejs-bugs
branch
from
January 9, 2025 11:04
5c1f430
to
f574451
Compare
cbeauchesne
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The more tests the better
Changes
main
Workflow
codeowners
file quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>]
, double-check that only<language>
is impacted by the changebuild-XXX-image
label is present