Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Debugger] Re-enable Node.js tests that should now be working #3582

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

watson
Copy link
Contributor

@watson watson commented Nov 28, 2024

Motivation

The more tests the better

Changes

  • Re-enable Node.js tests that should now be working due to changes to the schema already merged into main

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

Copy link
Contributor Author

watson commented Nov 28, 2024

@watson watson requested a review from a team November 28, 2024 14:50
@watson watson force-pushed the watson/fix-nodejs-bugs branch from 4651c33 to 0f6ffb3 Compare December 3, 2024 12:47
@watson watson force-pushed the watson/probe-has-version branch from 9a29d68 to 9f8b315 Compare December 12, 2024 19:34
Base automatically changed from watson/probe-has-version to main December 16, 2024 08:06
@watson watson force-pushed the watson/fix-nodejs-bugs branch from 0f6ffb3 to 6e6fe11 Compare January 7, 2025 08:36
@watson watson changed the base branch from main to watson/12-17-_debugger_ensure_all_probes_have_a_version_property January 7, 2025 08:36
@watson watson changed the title [Debugger] Fix diagnostics schema [Debugger] Re-enable Node.js tests that should now be working Jan 7, 2025
Base automatically changed from watson/12-17-_debugger_ensure_all_probes_have_a_version_property to main January 7, 2025 09:41
@watson watson force-pushed the watson/fix-nodejs-bugs branch from 6e6fe11 to 3f61ff5 Compare January 7, 2025 09:54
@watson watson marked this pull request as ready for review January 7, 2025 09:54
@watson watson requested a review from a team as a code owner January 7, 2025 09:54
@watson watson marked this pull request as draft January 7, 2025 11:18
@watson watson force-pushed the watson/fix-nodejs-bugs branch from 3f61ff5 to 5c1f430 Compare January 8, 2025 08:46
watson added 3 commits January 9, 2025 12:04
- The root `message` property is not expected.
- The probe version should be encoded in a `version` property - not a
  `probeVersion` property.
@watson watson force-pushed the watson/fix-nodejs-bugs branch from 5c1f430 to f574451 Compare January 9, 2025 11:04
@watson watson requested a review from cbeauchesne January 9, 2025 11:05
@watson watson marked this pull request as ready for review January 9, 2025 13:12
@watson watson merged commit 82eb9e2 into main Jan 9, 2025
432 of 433 checks passed
@watson watson deleted the watson/fix-nodejs-bugs branch January 9, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants