Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IAST Security Control tests for java springboot #3576

Merged
merged 5 commits into from
Jan 13, 2025

Conversation

jandro996
Copy link
Member

@jandro996 jandro996 commented Nov 28, 2024

Motivation

Add Iast security controls system tests for Milestone 0 (RFC)

Changes

New test_security_controls.py that covers all the RFC test cases

DD_IAST_SECURITY_CONTROLS_CONFIGURATION variable will differ for each tracer, as it represents the configuration of the security controls. For instance, in Java, a possible value could be:

INPUT_VALIDATOR:COMMAND_INJECTION:bar.foo.CustomInputValidator:validate,

whereas for Node.js it might be:

INPUT_VALIDATOR:COMMAND_INJECTION:bar/foo/custom_input_validator.js:validate.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@jandro996
Copy link
Member Author

@cbeauchesne any ideas related with the DD_IAST_SECURITY_CONTROLS_CONFIGURATION configurable for different tracers?

@cbeauchesne cbeauchesne force-pushed the alejandro.gonzalez/security-controls branch from 8b5d43c to bac103c Compare November 28, 2024 12:08
@jandro996 jandro996 force-pushed the alejandro.gonzalez/security-controls branch from 9fe9c2c to a7b3ea7 Compare December 20, 2024 10:31
@jandro996 jandro996 force-pushed the alejandro.gonzalez/security-controls branch from f30349a to 8b5eab8 Compare January 7, 2025 09:12
@jandro996 jandro996 force-pushed the alejandro.gonzalez/security-controls branch from 8b5eab8 to ffab521 Compare January 9, 2025 09:07
@jandro996 jandro996 marked this pull request as ready for review January 10, 2025 06:48
@jandro996 jandro996 requested review from a team as code owners January 10, 2025 06:48
@jandro996 jandro996 removed the request for review from a team January 10, 2025 06:48
@jandro996 jandro996 requested review from wantsui, sabrenner, manuel-alvarez-alvarez, Mariovido and cataphract and removed request for a team January 10, 2025 06:48
@jandro996 jandro996 merged commit cd3cac2 into main Jan 13, 2025
433 checks passed
@jandro996 jandro996 deleted the alejandro.gonzalez/security-controls branch January 13, 2025 11:59
@iunanua iunanua mentioned this pull request Jan 22, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants