Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APMSP-1765] Extract retry logic from SendData #852

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

VianneyRuhlmann
Copy link
Contributor

@VianneyRuhlmann VianneyRuhlmann commented Feb 4, 2025

What does this PR do?

This PR extract the retry logic from SendData::send_payload to a separate module to be reused in data-pipeline without the ownership constraints of SendData.

Motivation

The data-pipeline trace_payload is received as a reference to tracer memory which means it shouldn't be considered as static or owned.

Additional Notes

  • SendData::create_request_builder has been removed to use Endpoint request builder
  • Endpoint::into_request_builder was renamed to to_request_builder to match naming conventions on ownership
  • Some headers previously added in send_payload have been moved to send_with_protobuf and send_with_msgpack

How to test the change?

Existing tests still pass showing no changes in SendData behavior.

@VianneyRuhlmann VianneyRuhlmann changed the title Rename into_request_builder to match naming convention Extract retry logic from SendData Feb 4, 2025
@VianneyRuhlmann VianneyRuhlmann changed the title Extract retry logic from SendData [APMSP-1765] Extract retry logic from SendData Feb 4, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 89.10615% with 39 lines in your changes missing coverage. Please review.

Project coverage is 71.55%. Comparing base (c73b450) to head (03b5db7).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #852      +/-   ##
==========================================
+ Coverage   71.43%   71.55%   +0.12%     
==========================================
  Files         316      318       +2     
  Lines       46556    46711     +155     
==========================================
+ Hits        33258    33426     +168     
+ Misses      13298    13285      -13     
Components Coverage Δ
crashtracker 42.32% <ø> (-0.34%) ⬇️
crashtracker-ffi 6.38% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 91.48% <100.00%> (ø)
data-pipeline-ffi 90.08% <ø> (ø)
ddcommon 80.61% <100.00%> (+0.37%) ⬆️
ddcommon-ffi 62.11% <ø> (ø)
ddtelemetry 59.51% <100.00%> (ø)
ddtelemetry-ffi 22.46% <ø> (ø)
dogstatsd 90.01% <ø> (-0.29%) ⬇️
dogstatsd-client 79.77% <ø> (ø)
ipc 82.68% <ø> (-0.12%) ⬇️
profiling 80.23% <100.00%> (+1.26%) ⬆️
profiling-ffi 70.44% <ø> (+2.77%) ⬆️
serverless 0.00% <ø> (ø)
sidecar 41.79% <ø> (ø)
sidecar-ffi 10.78% <ø> (ø)
spawn-worker 54.37% <ø> (ø)
tinybytes 93.60% <ø> (ø)
trace-mini-agent 72.48% <ø> (ø)
trace-normalization 98.23% <ø> (ø)
trace-obfuscation 95.96% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.56% <89.17%> (-0.58%) ⬇️

@pr-commenter
Copy link

pr-commenter bot commented Feb 4, 2025

Benchmarks

Comparison

Benchmark execution time: 2025-02-04 17:41:35

Comparing candidate commit 03b5db7 in PR branch vianney/send-with-retry with baseline commit 03ca950 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 03b5db7 1738690234 vianney/send-with-retry
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 4.275µs 4.289µs ± 0.005µs 4.289µs ± 0.001µs 4.290µs 4.293µs 4.294µs 4.347µs 1.36% 9.272 114.118 0.11% 0.000µs 1 200
credit_card/is_card_number/ throughput 230031227.824op/s 233139948.912op/s ± 253040.352op/s 233158789.185op/s ± 61666.600op/s 233215415.539op/s 233354858.987op/s 233456653.082op/s 233904684.643op/s 0.32% -9.173 112.616 0.11% 17892.655op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 89.370µs 90.896µs ± 0.589µs 90.878µs ± 0.366µs 91.241µs 91.699µs 92.099µs 95.058µs 4.60% 1.641 11.299 0.65% 0.042µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 10519911.227op/s 11002087.961op/s ± 70579.735op/s 11003704.397op/s ± 44481.162op/s 11048100.670op/s 11100872.648op/s 11152550.404op/s 11189480.424op/s 1.69% -1.445 9.782 0.64% 4990.741op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 83.051µs 83.623µs ± 0.381µs 83.601µs ± 0.150µs 83.755µs 83.946µs 84.102µs 88.111µs 5.39% 8.204 94.947 0.45% 0.027µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 11349322.890op/s 11958662.196op/s ± 52513.093op/s 11961560.927op/s ± 21515.205op/s 11981965.047op/s 12007964.042op/s 12022938.380op/s 12040777.296op/s 0.66% -7.806 88.850 0.44% 3713.236op/s 1 200
credit_card/is_card_number/37828224631 execution_time 4.270µs 4.289µs ± 0.004µs 4.289µs ± 0.001µs 4.290µs 4.293µs 4.296µs 4.333µs 1.04% 4.992 55.925 0.10% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 230778693.031op/s 233166994.055op/s ± 233281.019op/s 233176973.830op/s ± 81295.800op/s 233243494.092op/s 233484878.403op/s 233524829.392op/s 234183171.208op/s 0.43% -4.893 54.823 0.10% 16495.459op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 80.389µs 80.922µs ± 0.156µs 80.912µs ± 0.039µs 80.957µs 81.181µs 81.511µs 81.547µs 0.79% 1.175 5.375 0.19% 0.011µs 1 200
credit_card/is_card_number/378282246310005 throughput 12262819.517op/s 12357553.812op/s ± 23735.721op/s 12359140.065op/s ± 6026.308op/s 12364623.268op/s 12389244.003op/s 12419438.173op/s 12439490.406op/s 0.65% -1.141 5.323 0.19% 1678.369op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 58.508µs 58.682µs ± 0.050µs 58.684µs ± 0.024µs 58.707µs 58.769µs 58.796µs 58.831µs 0.25% -0.134 1.212 0.08% 0.004µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 16997902.101op/s 17041004.268op/s ± 14403.337op/s 17040464.027op/s ± 7113.352op/s 17048001.889op/s 17065562.122op/s 17079808.285op/s 17091667.812op/s 0.30% 0.142 1.218 0.08% 1018.470op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.421µs 6.444µs ± 0.004µs 6.444µs ± 0.002µs 6.446µs 6.451µs 6.454µs 6.462µs 0.27% -0.386 5.463 0.06% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 154762517.316op/s 155182632.155op/s ± 100560.204op/s 155178934.460op/s ± 51588.352op/s 155230425.169op/s 155336327.872op/s 155408404.710op/s 155735965.325op/s 0.36% 0.400 5.499 0.06% 7110.680op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 4.271µs 4.288µs ± 0.003µs 4.288µs ± 0.002µs 4.290µs 4.293µs 4.295µs 4.296µs 0.18% -0.744 5.650 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 232768449.968op/s 233190270.766op/s ± 158012.762op/s 233192090.364op/s ± 87583.455op/s 233282206.402op/s 233408864.235op/s 233536810.063op/s 234126677.887op/s 0.40% 0.758 5.725 0.07% 11173.190op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 69.161µs 69.960µs ± 0.340µs 69.928µs ± 0.204µs 70.168µs 70.563µs 70.872µs 71.232µs 1.86% 0.509 0.791 0.49% 0.024µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 14038667.169op/s 14294120.703op/s ± 69379.611op/s 14300355.128op/s ± 41893.673op/s 14337178.077op/s 14391619.046op/s 14453515.693op/s 14459020.275op/s 1.11% -0.472 0.734 0.48% 4905.879op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 63.974µs 64.903µs ± 0.427µs 64.905µs ± 0.296µs 65.202µs 65.692µs 65.852µs 66.077µs 1.81% 0.102 -0.337 0.66% 0.030µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 15133762.937op/s 15408347.917op/s ± 101296.145op/s 15407057.706op/s ± 70684.533op/s 15477588.070op/s 15576978.421op/s 15612247.450op/s 15631354.965op/s 1.46% -0.070 -0.358 0.66% 7162.719op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 4.272µs 4.288µs ± 0.003µs 4.288µs ± 0.001µs 4.290µs 4.292µs 4.294µs 4.295µs 0.16% -0.997 6.050 0.06% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 232812862.367op/s 233191822.645op/s ± 146924.586op/s 233196437.463op/s ± 72712.508op/s 233256346.075op/s 233411812.439op/s 233541794.305op/s 234076783.807op/s 0.38% 1.010 6.124 0.06% 10389.137op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 61.770µs 61.956µs ± 0.059µs 61.962µs ± 0.036µs 61.996µs 62.045µs 62.079µs 62.085µs 0.20% -0.382 -0.079 0.10% 0.004µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 16106978.975op/s 16140425.356op/s ± 15480.426op/s 16138928.680op/s ± 9267.712op/s 16148537.039op/s 16169832.591op/s 16174369.803op/s 16189159.739op/s 0.31% 0.387 -0.075 0.10% 1094.631op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 58.562µs 58.677µs ± 0.041µs 58.678µs ± 0.027µs 58.705µs 58.744µs 58.765µs 58.841µs 0.28% 0.145 0.931 0.07% 0.003µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 16994932.230op/s 17042427.887op/s ± 11910.642op/s 17042296.490op/s ± 7938.389op/s 17050303.480op/s 17061748.328op/s 17072233.142op/s 17075825.753op/s 0.20% -0.139 0.922 0.07% 842.210op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.418µs 6.444µs ± 0.004µs 6.444µs ± 0.002µs 6.446µs 6.450µs 6.457µs 6.461µs 0.27% -0.282 8.097 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 154768613.444op/s 155185008.977op/s ± 102262.142op/s 155193831.046op/s ± 45446.684op/s 155232932.676op/s 155325039.779op/s 155385515.505op/s 155801018.007op/s 0.39% 0.302 8.160 0.07% 7231.025op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [4.289µs; 4.290µs] or [-0.015%; +0.015%] None None None
credit_card/is_card_number/ throughput [233104879.953op/s; 233175017.871op/s] or [-0.015%; +0.015%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [90.814µs; 90.977µs] or [-0.090%; +0.090%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [10992306.289op/s; 11011869.634op/s] or [-0.089%; +0.089%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [83.570µs; 83.676µs] or [-0.063%; +0.063%] None None None
credit_card/is_card_number/ 378282246310005 throughput [11951384.386op/s; 11965940.006op/s] or [-0.061%; +0.061%] None None None
credit_card/is_card_number/37828224631 execution_time [4.288µs; 4.289µs] or [-0.014%; +0.014%] None None None
credit_card/is_card_number/37828224631 throughput [233134663.549op/s; 233199324.560op/s] or [-0.014%; +0.014%] None None None
credit_card/is_card_number/378282246310005 execution_time [80.901µs; 80.944µs] or [-0.027%; +0.027%] None None None
credit_card/is_card_number/378282246310005 throughput [12354264.269op/s; 12360843.354op/s] or [-0.027%; +0.027%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [58.675µs; 58.689µs] or [-0.012%; +0.012%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [17039008.104op/s; 17043000.432op/s] or [-0.012%; +0.012%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.443µs; 6.445µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/x371413321323331 throughput [155168695.478op/s; 155196568.833op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/ execution_time [4.288µs; 4.289µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/ throughput [233168371.717op/s; 233212169.816op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [69.913µs; 70.008µs] or [-0.067%; +0.067%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [14284505.357op/s; 14303736.050op/s] or [-0.067%; +0.067%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [64.844µs; 64.962µs] or [-0.091%; +0.091%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [15394309.246op/s; 15422386.589op/s] or [-0.091%; +0.091%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [4.288µs; 4.289µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [233171460.311op/s; 233212184.980op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [61.948µs; 61.965µs] or [-0.013%; +0.013%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [16138279.918op/s; 16142570.795op/s] or [-0.013%; +0.013%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [58.671µs; 58.683µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [17040777.186op/s; 17044078.587op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.443µs; 6.445µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [155170836.428op/s; 155199181.527op/s] or [-0.009%; +0.009%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 03b5db7 1738690234 vianney/send-with-retry
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 5.383µs 5.481µs ± 0.044µs 5.484µs ± 0.029µs 5.512µs 5.559µs 5.565µs 5.568µs 1.53% -0.037 -0.657 0.80% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.475µs; 5.487µs] or [-0.111%; +0.111%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 03b5db7 1738690234 vianney/send-with-retry
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 39.741µs 40.295µs ± 0.758µs 39.947µs ± 0.092µs 40.114µs 41.861µs 41.901µs 43.574µs 9.08% 1.783 1.859 1.88% 0.054µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [40.190µs; 40.400µs] or [-0.261%; +0.261%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 03b5db7 1738690234 vianney/send-with-retry
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 6.369ms 6.384ms ± 0.007ms 6.384ms ± 0.004ms 6.388ms 6.394ms 6.397ms 6.445ms 0.97% 2.792 22.426 0.12% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [6.383ms; 6.385ms] or [-0.016%; +0.016%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 03b5db7 1738690234 vianney/send-with-retry
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 180.045µs 183.820µs ± 1.910µs 183.643µs ± 1.376µs 185.145µs 187.283µs 188.144µs 189.810µs 3.36% 0.445 -0.381 1.04% 0.135µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 5268430.485op/s 5440698.914op/s ± 56277.517op/s 5445361.906op/s ± 41107.192op/s 5483459.865op/s 5522631.022op/s 5534264.039op/s 5554172.412op/s 2.00% -0.401 -0.445 1.03% 3979.421op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 20.823µs 21.164µs ± 0.152µs 21.195µs ± 0.111µs 21.262µs 21.377µs 21.610µs 21.681µs 2.30% 0.322 0.401 0.71% 0.011µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 46123035.219op/s 47252795.316op/s ± 337795.498op/s 47181778.585op/s ± 247038.180op/s 47507076.739op/s 47767000.627op/s 47865435.592op/s 48023779.353op/s 1.78% -0.274 0.295 0.71% 23885.749op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 14.186µs 14.266µs ± 0.042µs 14.263µs ± 0.026µs 14.289µs 14.347µs 14.394µs 14.415µs 1.07% 0.870 1.167 0.30% 0.003µs 1 200
normalization/normalize_name/normalize_name/good throughput 69372260.007op/s 70095808.284op/s ± 207164.207op/s 70112396.511op/s ± 127507.007op/s 70237681.757op/s 70384228.082op/s 70457637.450op/s 70491792.005op/s 0.54% -0.849 1.115 0.29% 14648.722op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [183.555µs; 184.084µs] or [-0.144%; +0.144%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [5432899.392op/s; 5448498.437op/s] or [-0.143%; +0.143%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [21.143µs; 21.185µs] or [-0.099%; +0.099%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [47205980.108op/s; 47299610.523op/s] or [-0.099%; +0.099%] None None None
normalization/normalize_name/normalize_name/good execution_time [14.260µs; 14.272µs] or [-0.041%; +0.041%] None None None
normalization/normalize_name/normalize_name/good throughput [70067097.317op/s; 70124519.250op/s] or [-0.041%; +0.041%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 03b5db7 1738690234 vianney/send-with-retry
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.390µs 3.311µs ± 1.466µs 3.120µs ± 0.034µs 3.149µs 3.754µs 14.323µs 15.390µs 393.31% 7.441 56.111 44.16% 0.104µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.108µs; 3.514µs] or [-6.135%; +6.135%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 03b5db7 1738690234 vianney/send-with-retry
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 263.982ns 274.354ns ± 13.788ns 267.835ns ± 2.321ns 275.720ns 305.433ns 314.876ns 320.516ns 19.67% 1.757 1.795 5.01% 0.975ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [272.444ns; 276.265ns] or [-0.697%; +0.697%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 03b5db7 1738690234 vianney/send-with-retry
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 18.486µs 27.988µs ± 14.070µs 18.973µs ± 0.447µs 36.734µs 46.539µs 59.342µs 149.153µs 686.12% 3.863 27.637 50.15% 0.995µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [26.038µs; 29.938µs] or [-6.967%; +6.967%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 03b5db7 1738690234 vianney/send-with-retry
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 58.716ms 59.336ms ± 0.333ms 59.487ms ± 0.143ms 59.539ms 59.807ms 60.095ms 60.174ms 1.16% -0.185 -0.761 0.56% 0.024ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [59.289ms; 59.382ms] or [-0.078%; +0.078%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 03b5db7 1738690234 vianney/send-with-retry
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.699µs 2.755µs ± 0.019µs 2.751µs ± 0.006µs 2.761µs 2.799µs 2.806µs 2.808µs 2.08% 0.652 1.889 0.68% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.752µs; 2.757µs] or [-0.095%; +0.095%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 03b5db7 1738690234 vianney/send-with-retry
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 699.879µs 701.654µs ± 0.937µs 701.541µs ± 0.347µs 701.902µs 702.514µs 706.437µs 710.138µs 1.23% 5.152 39.060 0.13% 0.066µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1408177.002op/s 1425205.629op/s ± 1890.216op/s 1425433.751op/s ± 704.118op/s 1426080.489op/s 1426930.302op/s 1427571.059op/s 1428817.782op/s 0.24% -5.094 38.387 0.13% 133.658op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 472.917µs 473.860µs ± 0.393µs 473.875µs ± 0.267µs 474.106µs 474.513µs 474.770µs 474.929µs 0.22% 0.117 -0.127 0.08% 0.028µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2105578.353op/s 2110330.940op/s ± 1749.387op/s 2110261.379op/s ± 1188.737op/s 2111605.579op/s 2113235.159op/s 2114277.709op/s 2114536.661op/s 0.20% -0.112 -0.129 0.08% 123.700op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 190.619µs 191.094µs ± 0.164µs 191.089µs ± 0.113µs 191.206µs 191.367µs 191.445µs 191.542µs 0.24% 0.064 -0.331 0.09% 0.012µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5220780.796op/s 5233041.906op/s ± 4481.009op/s 5233161.498op/s ± 3095.242op/s 5236049.854op/s 5240393.970op/s 5241925.127op/s 5246077.347op/s 0.25% -0.060 -0.331 0.09% 316.855op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 46.204µs 46.390µs ± 0.071µs 46.391µs ± 0.048µs 46.438µs 46.496µs 46.552µs 46.569µs 0.38% 0.019 -0.132 0.15% 0.005µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 21473626.883op/s 21556269.880op/s ± 32771.813op/s 21555900.303op/s ± 22140.711op/s 21577868.639op/s 21613329.925op/s 21628921.943op/s 21643267.378op/s 0.41% -0.011 -0.133 0.15% 2317.317op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 49.028µs 49.441µs ± 0.129µs 49.437µs ± 0.043µs 49.487µs 49.570µs 49.645µs 50.717µs 2.59% 4.272 46.932 0.26% 0.009µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 19717254.569op/s 20226268.202op/s ± 52355.903op/s 20227964.667op/s ± 17647.118op/s 20242910.432op/s 20284220.029op/s 20380332.236op/s 20396549.720op/s 0.83% -4.035 44.392 0.26% 3702.121op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [701.525µs; 701.784µs] or [-0.019%; +0.019%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1424943.663op/s; 1425467.595op/s] or [-0.018%; +0.018%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [473.805µs; 473.914µs] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2110088.491op/s; 2110573.388op/s] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [191.071µs; 191.116µs] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5232420.881op/s; 5233662.931op/s] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [46.381µs; 46.400µs] or [-0.021%; +0.021%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [21551728.022op/s; 21560811.738op/s] or [-0.021%; +0.021%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [49.423µs; 49.459µs] or [-0.036%; +0.036%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20219012.177op/s; 20233524.226op/s] or [-0.036%; +0.036%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 03b5db7 1738690234 vianney/send-with-retry
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 138.208µs 139.126µs ± 0.495µs 139.021µs ± 0.147µs 139.198µs 139.743µs 141.227µs 142.796µs 2.71% 4.129 25.118 0.36% 0.035µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [139.057µs; 139.195µs] or [-0.049%; +0.049%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 03b5db7 1738690234 vianney/send-with-retry
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 68.603µs 68.837µs ± 0.168µs 68.822µs ± 0.053µs 68.876µs 68.986µs 69.138µs 70.721µs 2.76% 7.606 79.914 0.24% 0.012µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [68.814µs; 68.860µs] or [-0.034%; +0.034%] None None None

Baseline

Omitted due to size.

@VianneyRuhlmann VianneyRuhlmann force-pushed the vianney/send-with-retry branch 2 times, most recently from 5a04f3e to 619bb76 Compare February 4, 2025 17:11
@VianneyRuhlmann VianneyRuhlmann force-pushed the vianney/send-with-retry branch from 619bb76 to 03b5db7 Compare February 4, 2025 17:30
@VianneyRuhlmann VianneyRuhlmann marked this pull request as ready for review February 5, 2025 09:09
@VianneyRuhlmann VianneyRuhlmann requested review from a team as code owners February 5, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants