You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR extract the retry logic from SendData::send_payload to a separate module to be reused in data-pipeline without the ownership constraints of SendData.
Motivation
The data-pipeline trace_payload is received as a reference to tracer memory which means it shouldn't be considered as static or owned.
Additional Notes
SendData::create_request_builder has been removed to use Endpoint request builder
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR extract the retry logic from
SendData::send_payload
to a separate module to be reused indata-pipeline
without the ownership constraints ofSendData
.Motivation
The data-pipeline trace_payload is received as a reference to tracer memory which means it shouldn't be considered as static or owned.
Additional Notes
SendData::create_request_builder
has been removed to useEndpoint
request builderEndpoint::into_request_builder
was renamed toto_request_builder
to match naming conventions on ownershipsend_payload
have been moved tosend_with_protobuf
andsend_with_msgpack
How to test the change?
Existing tests still pass showing no changes in SendData behavior.