Svls 6036 respect timeouts #851
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #851 +/- ##
==========================================
+ Coverage 71.44% 72.07% +0.63%
==========================================
Files 317 323 +6
Lines 46656 47968 +1312
==========================================
+ Hits 33334 34574 +1240
- Misses 13322 13394 +72
|
astuyve
reviewed
Feb 4, 2025
astuyve
reviewed
Feb 4, 2025
astuyve
approved these changes
Feb 4, 2025
BenchmarksComparisonBenchmark execution time: 2025-02-05 20:36:13 Comparing candidate commit 1470851 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
BaselineOmitted due to size. |
morrisonlevi
reviewed
Feb 4, 2025
danielsn
requested changes
Feb 4, 2025
dogstatsd/src/datadog.rs
Outdated
| .send() | ||
| .await; | ||
| debug!("Sending body: {:?}", &series); | ||
| let body = serde_json::to_vec(&series).expect("failed to serialize series"); |
There was a problem hiding this comment.
Suggested change
| let body = serde_json::to_vec(&series).expect("failed to serialize series"); | |
| let body = serde_json::to_vec(&series).context("failed to serialize series")?; |
Lets avoid the use of panic as much as possible.
There was a problem hiding this comment.
I just moved the old behavior, but agree, I will handle the error safely
dogstatsd/src/datadog.rs
Outdated
| let url = format!("{}/api/beta/sketches", &self.metrics_intake_url_prefix); | ||
| debug!("Sending distributions: {:?}", &sketches); | ||
| let body = sketches.write_to_bytes().expect("can't write to buffer"); |
There was a problem hiding this comment.
Suggested change
| let body = sketches.write_to_bytes().expect("can't write to buffer"); | |
| let body = sketches.write_to_bytes().context("can't write to buffer")?; |
There was a problem hiding this comment.
I just moved the old behavior, but agree, I will handle the error safely
astuyve
approved these changes
Feb 7, 2025
astuyve
reviewed
Feb 7, 2025
| self.dd_api.ship_series(&a_batch).await; | ||
| // TODO(astuyve) retry and do not panic | ||
| let dd_api_clone = self.dd_api.clone(); | ||
| tokio::spawn(async move { |
There was a problem hiding this comment.
Do we wait for this to return when we flush? Otherwise we may lose data here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change make the configured flushing time out respected