Skip to content

[AGTMETRICS-393] Update Agent Data Plane support to reflect new "Data Plane" terminology. #2313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gh-worker-dd-mergequeue-cf854d merged 6 commits into from
Jan 26, 2026
Merged

[AGTMETRICS-393] Update Agent Data Plane support to reflect new "Data Plane" terminology. #2313

gh-worker-dd-mergequeue-cf854d merged 6 commits into from
Jan 26, 2026

Conversation

@tobz
Copy link
Member

@tobz tobz commented Jan 21, 2026 •
edited
Loading

What this PR does / why we need it:

This PR updates how our support for Agent Data Plane is exposed by reworking it towards the more generic "Data Plane" terminology that we've begun to use elsewhere.

Notable changes here:

  • switch from datadog.agentDataPlane to datadog.dataPlane for ADP-specific configuration settings
  • updating to the latest version of ADP (0.1.30)
  • exposing a new configuration setting for enabling individual data pipelines (currently, only DogStatsD)
  • refactoring template generation to use more helper includes to better isolate when/how we decide to enable ADP and inject the relevant data plane-specific environment variables on the Core Agent container
  • added two new test baselines for capturing some Agent version-specific behavior differences (7.74 vs 7.75, when ADP is enabled).

Additionally, I realize this is a breaking change in terms of the configuration values. We generally consider this to be experimental, and, honestly, we don't actually know of any customers using ADP via the Helm chart yet (😅) which is why we're just making the change now to get it out of the way without any long period of backwards-compatible setting handling, etc. Happy to discuss this more if it seems like an issue.

Which issue this PR fixes

N/A

Special notes for your reviewer:

I did the following local tests by installing the chart in a basic Kind cluster:

  • data plane not enabled: continues to work (expected)
  • data plane enabled, no data pipelines enabled: fails during render with warning about no enabled data pipelines (expected)
  • data plane enabled, dogstatsd pipeline enabled, Agent version set to 7.74: ADP container present and running, ADP handling DSD, DD_USE_DOGSTATSD: false set on Core Agent container (expected)
  • data plane enabled, dogstatsd pipeline enabled, Agent version set to 7.75: ADP container present and running, ADP handling DSD, DD_USE_DOGSTATSD not set on Core Agent container (expected)

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • All commits are signed (see: signing commits)
  • Chart Version semver bump label has been added (use <chartName>/minor-version, <chartName>/patch-version, or <chartName>/no-version-bump)
  • For datadog or datadog-operator chart or value changes, update the test baselines (run: make update-test-baselines)

GitHub CI takes care of the below, but are still required:

  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated
  • Variables are documented in the README.md

@tobz tobz requested a review from a team as a code owner January 21, 2026 18:42
@tobz tobz added the datadog/minor-version Minor version bump for datadog chart label Jan 21, 2026
@tobz tobz force-pushed the tobz/adp-update-to-0-1-30 branch from edebb67 to 40e27c1 Compare January 21, 2026 19:03
@github-actions github-actions bot added the chart/datadog This issue or pull request is related to the datadog chart label Jan 21, 2026
@tobz tobz mentioned this pull request Jan 21, 2026
Closed
6 tasks
@tobz tobz force-pushed the tobz/adp-update-to-0-1-30 branch from 4a58507 to d28902b Compare January 21, 2026 19:12
@fanny-jiang fanny-jiang requested a review from a team January 21, 2026 21:12
@tobz tobz force-pushed the tobz/adp-update-to-0-1-30 branch from f4bf62f to 9b49755 Compare January 21, 2026 21:31
@tobz tobz force-pushed the tobz/adp-update-to-0-1-30 branch from ec5faaa to f2581c1 Compare January 26, 2026 18:52
@tobz tobz force-pushed the tobz/adp-update-to-0-1-30 branch from 8c06b12 to 430a176 Compare January 26, 2026 18:57
@dd-octo-sts
chore: update charts
c234242 
- bump version for datadog to 3.163.0 (minor-version)
- update changelog for datadog with version 3.163.0
- update readme for datadog
@tobz
Copy link
Member Author

tobz commented Jan 26, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link

gh-worker-devflow-routing-ef8351 bot commented Jan 26, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-01-26 19:44:12 UTC ℹ️ Start processing command /merge

2026-01-26 19:44:26 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 50m (p90).

2026-01-26 20:32:42 UTC 🚨 MergeQueue: This merge request is in error

mergequeue build completed successfully, but the github api returned an error while merging the pr.
It's probably because:

  • target branch of PR is restricted to only allow up-to-date branches, but the pr is now outdated
Details

Error: PUT https://api.github.com/repos/DataDog/helm-charts/pulls/2313/merge: 405 Required status check "pr-validated" is expected. [] (Request ID: C7E0:44CD0:308D9C5:D8DA2BE:6977CF63)

FullStacktrace:
activity error (type: github.GithubService_MergePullRequest, scheduledEventID: 52, startedEventID: 53, identity: 1@github-worker-7587f6b96c-fjdtb@): PUT https://api.github.com/repos/DataDog/helm-charts/pulls/2313/merge: 405 Required status check "pr-validated" is expected. [] (Request ID: C7E0:44CD0:308D9C5:D8DA2BE:6977CF63) (type: GitFailure, retryable: false): PUT https://api.github.com/repos/DataDog/helm-charts/pulls/2313/merge: 405 Required status check "pr-validated" is expected. [] (type: ErrorResponse, retryable: true)

@tobz
Copy link
Member Author

tobz commented Jan 26, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link

gh-worker-devflow-routing-ef8351 bot commented Jan 26, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-01-26 20:33:47 UTC ℹ️ Start processing command /merge

2026-01-26 20:34:06 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 50m (p90).

2026-01-26 21:17:15 UTC ❌ MergeQueue: This merge request is not mergeable, blocked by github

PR can't be merged according to github policy

@tobz
Copy link
Member Author

tobz commented Jan 26, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link

gh-worker-devflow-routing-ef8351 bot commented Jan 26, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-01-26 21:45:59 UTC ℹ️ Start processing command /merge

2026-01-26 21:46:08 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 50m (p90).

2026-01-26 22:35:03 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit 6aa1183 into main Jan 26, 2026
37 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the tobz/adp-update-to-0-1-30 branch January 26, 2026 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fanny-jiang fanny-jiang fanny-jiang approved these changes

@urseberry urseberry urseberry approved these changes

Assignees

No one assigned

Labels

chart/datadog This issue or pull request is related to the datadog chart datadog/minor-version Minor version bump for datadog chart mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tobz @fanny-jiang @urseberry