Skip to content

chore(profiling): remove unused method on StackRenderer #16579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gh-worker-dd-mergequeue-cf854d merged 1 commit into from
Feb 19, 2026
+0 −10
Merged

chore(profiling): remove unused method on StackRenderer #16579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ddtrace/internal/datadog/profiling/stack/include/stack_renderer.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ class StackRenderer
uintptr_t thread_id,
unsigned long native_id);
void render_task_begin(const std::string& task_name, bool on_cpu);
void render_stack_begin();
void render_frame(Frame& frame);
void render_cpu_time(uint64_t cpu_time_us);
void render_stack_end();
Expand Down
3 changes: 0 additions & 3 deletions ddtrace/internal/datadog/profiling/stack/src/echion/threads.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -645,7 +645,6 @@ ThreadInfo::sample(EchionSampler& echion, PyThreadState* tstate, microsecond_t d

const auto& task_name = maybe_task_name->get();
renderer.render_task_begin(task_name, task_stack_info->on_cpu);
renderer.render_stack_begin();

task_stack_info->stack.render(echion);

Expand All @@ -662,7 +661,6 @@ ThreadInfo::sample(EchionSampler& echion, PyThreadState* tstate, microsecond_t d

const auto& task_name = maybe_task_name->get();
renderer.render_task_begin(task_name, greenlet_stack->on_cpu);
renderer.render_stack_begin();

auto& stack = greenlet_stack->stack;
stack.render(echion);
Expand All @@ -672,7 +670,6 @@ ThreadInfo::sample(EchionSampler& echion, PyThreadState* tstate, microsecond_t d

current_greenlets.clear();
} else {
renderer.render_stack_begin();
python_stack.render(echion);
renderer.render_stack_end();
}
Expand Down
6 changes: 0 additions & 6 deletions ddtrace/internal/datadog/profiling/stack/src/stack_renderer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,12 +110,6 @@ StackRenderer::render_task_begin(const std::string& task_name, bool on_cpu)
pushed_task_name = true;
}

void
StackRenderer::render_stack_begin()
{
// This function is part of the necessary API, but it is unused by the Datadog profiler for now.
}

void
StackRenderer::render_frame(Frame& frame)
{
Expand Down