chore: add missing typing for bytecode utilities#16573
chore: add missing typing for bytecode utilities#16573gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits intomainfrom
Conversation
We add missing typing information for the bytecode utilities such as function wrapping and injection.
Codeowners resolved as |
This comment has been minimized.
This comment has been minimized.
Performance SLOsComparing candidate gab/chore/bytecode-add-missing-typing (10c3f21) with baseline main (8f7b888) 📈 Performance Regressions (2 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 103.412µs (SLO: <130.000µs 📉 -20.5%) vs baseline: +3.6% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.8% ✅ add_inplace_aspectTime: ✅ 100.557µs (SLO: <130.000µs 📉 -22.6%) vs baseline: -1.3% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +5.0% ✅ add_inplace_noaspectTime: ✅ 28.370µs (SLO: <40.000µs 📉 -29.1%) vs baseline: +0.5% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.7% ✅ add_noaspectTime: ✅ 48.830µs (SLO: <70.000µs 📉 -30.2%) vs baseline: +0.6% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.6% ✅ bytearray_aspectTime: ✅ 251.475µs (SLO: <400.000µs 📉 -37.1%) vs baseline: +1.1% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.8% ✅ bytearray_extend_aspectTime: ✅ 634.393µs (SLO: <800.000µs 📉 -20.7%) vs baseline: -0.8% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +4.8% ✅ bytearray_extend_noaspectTime: ✅ 262.935µs (SLO: <400.000µs 📉 -34.3%) vs baseline: -0.7% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.9% ✅ bytearray_noaspectTime: ✅ 134.133µs (SLO: <300.000µs 📉 -55.3%) vs baseline: -0.9% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.9% ✅ bytes_aspectTime: ✅ 218.680µs (SLO: <300.000µs 📉 -27.1%) vs baseline: -0.3% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +5.0% ✅ bytes_noaspectTime: ✅ 133.492µs (SLO: <200.000µs 📉 -33.3%) vs baseline: -0.4% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.9% ✅ bytesio_aspectTime: ✅ 3.791ms (SLO: <5.000ms 📉 -24.2%) vs baseline: +0.6% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +5.0% ✅ bytesio_noaspectTime: ✅ 313.124µs (SLO: <420.000µs 📉 -25.4%) vs baseline: -1.0% Memory: ✅ 42.880MB (SLO: <46.000MB -6.8%) vs baseline: +4.7% ✅ capitalize_aspectTime: ✅ 89.440µs (SLO: <300.000µs 📉 -70.2%) vs baseline: -0.3% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.9% ✅ capitalize_noaspectTime: ✅ 252.568µs (SLO: <300.000µs 📉 -15.8%) vs baseline: +1.9% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.8% ✅ casefold_aspectTime: ✅ 89.358µs (SLO: <500.000µs 📉 -82.1%) vs baseline: +0.5% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.7% ✅ casefold_noaspectTime: ✅ 305.242µs (SLO: <500.000µs 📉 -39.0%) vs baseline: -0.9% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.8% ✅ decode_aspectTime: ✅ 86.477µs (SLO: <100.000µs 📉 -13.5%) vs baseline: +0.2% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.9% ✅ decode_noaspectTime: ✅ 152.722µs (SLO: <210.000µs 📉 -27.3%) vs baseline: -1.0% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +5.0% ✅ encode_aspectTime: ✅ 84.460µs (SLO: <200.000µs 📉 -57.8%) vs baseline: +0.3% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.9% ✅ encode_noaspectTime: ✅ 140.612µs (SLO: <200.000µs 📉 -29.7%) vs baseline: -0.8% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +4.9% ✅ format_aspectTime: ✅ 14.643ms (SLO: <19.200ms 📉 -23.7%) vs baseline: +0.3% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.7% ✅ format_map_aspectTime: ✅ 16.503ms (SLO: <21.500ms 📉 -23.2%) vs baseline: +0.2% Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +5.0% ✅ format_map_noaspectTime: ✅ 375.212µs (SLO: <500.000µs 📉 -25.0%) vs baseline: +1.5% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) ✅ format_noaspectTime: ✅ 305.777µs (SLO: <500.000µs 📉 -38.8%) vs baseline: +0.4% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.9% ✅ index_aspectTime: ✅ 126.431µs (SLO: <300.000µs 📉 -57.9%) vs baseline: +4.2% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +5.0% ✅ index_noaspectTime: ✅ 40.565µs (SLO: <300.000µs 📉 -86.5%) vs baseline: -0.1% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.8% ✅ join_aspectTime: ✅ 210.689µs (SLO: <300.000µs 📉 -29.8%) vs baseline: -0.4% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +5.0% ✅ join_noaspectTime: ✅ 143.889µs (SLO: <300.000µs 📉 -52.0%) vs baseline: +1.9% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +5.0% ✅ ljust_aspectTime: ✅ 583.142µs (SLO: <700.000µs 📉 -16.7%) vs baseline: 📈 +16.8% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +5.1% ✅ ljust_noaspectTime: ✅ 258.297µs (SLO: <300.000µs 📉 -13.9%) vs baseline: -0.5% Memory: ✅ 42.880MB (SLO: <46.000MB -6.8%) vs baseline: +4.9% ✅ lower_aspectTime: ✅ 295.456µs (SLO: <500.000µs 📉 -40.9%) vs baseline: -0.3% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.9% ✅ lower_noaspectTime: ✅ 235.435µs (SLO: <300.000µs 📉 -21.5%) vs baseline: ~same Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.9% ✅ lstrip_aspectTime: ✅ 0.270ms (SLO: <3.000ms 📉 -91.0%) vs baseline: +0.3% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.8% ✅ lstrip_noaspectTime: ✅ 0.177ms (SLO: <3.000ms 📉 -94.1%) vs baseline: +0.3% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +5.0% ✅ modulo_aspectTime: ✅ 14.281ms (SLO: <18.750ms 📉 -23.8%) vs baseline: -0.3% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.8% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 14.708ms (SLO: <19.350ms 📉 -24.0%) vs baseline: -0.5% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +5.0% ✅ modulo_aspect_for_bytesTime: ✅ 14.493ms (SLO: <18.900ms 📉 -23.3%) vs baseline: +0.7% Memory: ✅ 43.096MB (SLO: <46.000MB -6.3%) vs baseline: +5.1% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 14.625ms (SLO: <19.150ms 📉 -23.6%) vs baseline: ~same Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +4.7% ✅ modulo_noaspectTime: ✅ 0.361ms (SLO: <3.000ms 📉 -88.0%) vs baseline: ~same Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.8% ✅ replace_aspectTime: ✅ 18.476ms (SLO: <24.000ms 📉 -23.0%) vs baseline: +0.4% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.7% ✅ replace_noaspectTime: ✅ 282.792µs (SLO: <300.000µs -5.7%) vs baseline: +0.6% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.8% ✅ repr_aspectTime: ✅ 311.579µs (SLO: <420.000µs 📉 -25.8%) vs baseline: +0.2% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +5.0% ✅ repr_noaspectTime: ✅ 46.988µs (SLO: <90.000µs 📉 -47.8%) vs baseline: -0.2% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.9% ✅ rstrip_aspectTime: ✅ 386.782µs (SLO: <500.000µs 📉 -22.6%) vs baseline: -0.6% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.9% ✅ rstrip_noaspectTime: ✅ 185.577µs (SLO: <300.000µs 📉 -38.1%) vs baseline: +0.4% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.8% ✅ slice_aspectTime: ✅ 182.898µs (SLO: <300.000µs 📉 -39.0%) vs baseline: -0.8% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +5.0% ✅ slice_noaspectTime: ✅ 54.219µs (SLO: <90.000µs 📉 -39.8%) vs baseline: +0.3% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +5.1% ✅ stringio_aspectTime: ✅ 3.830ms (SLO: <5.000ms 📉 -23.4%) vs baseline: +0.2% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.8% ✅ stringio_noaspectTime: ✅ 379.204µs (SLO: <500.000µs 📉 -24.2%) vs baseline: +9.1% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) ✅ strip_aspectTime: ✅ 269.133µs (SLO: <350.000µs 📉 -23.1%) vs baseline: +0.2% Memory: ✅ 42.880MB (SLO: <46.000MB -6.8%) vs baseline: +4.7% ✅ strip_noaspectTime: ✅ 178.242µs (SLO: <240.000µs 📉 -25.7%) vs baseline: -0.9% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.7% ✅ swapcase_aspectTime: ✅ 332.497µs (SLO: <500.000µs 📉 -33.5%) vs baseline: ~same Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +5.0% ✅ swapcase_noaspectTime: ✅ 272.415µs (SLO: <400.000µs 📉 -31.9%) vs baseline: +1.0% Memory: ✅ 42.880MB (SLO: <46.000MB -6.8%) vs baseline: +4.7% ✅ title_aspectTime: ✅ 318.917µs (SLO: <500.000µs 📉 -36.2%) vs baseline: -0.7% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +4.9% ✅ title_noaspectTime: ✅ 258.679µs (SLO: <400.000µs 📉 -35.3%) vs baseline: -1.5% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.7% ✅ translate_aspectTime: ✅ 491.436µs (SLO: <700.000µs 📉 -29.8%) vs baseline: +0.5% Memory: ✅ 42.880MB (SLO: <46.000MB -6.8%) vs baseline: +4.8% ✅ translate_noaspectTime: ✅ 425.357µs (SLO: <500.000µs 📉 -14.9%) vs baseline: -0.9% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +5.0% ✅ upper_aspectTime: ✅ 295.607µs (SLO: <500.000µs 📉 -40.9%) vs baseline: ~same Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.9% ✅ upper_noaspectTime: ✅ 235.769µs (SLO: <400.000µs 📉 -41.1%) vs baseline: +0.6% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +5.0% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 511.976µs (SLO: <700.000µs 📉 -26.9%) vs baseline: 📈 +21.2% Memory: ✅ 42.861MB (SLO: <46.000MB -6.8%) vs baseline: +4.6% ✅ ospathbasename_noaspectTime: ✅ 431.756µs (SLO: <700.000µs 📉 -38.3%) vs baseline: -0.6% Memory: ✅ 42.861MB (SLO: <46.000MB -6.8%) vs baseline: +5.1% ✅ ospathjoin_aspectTime: ✅ 629.846µs (SLO: <700.000µs 📉 -10.0%) vs baseline: +0.4% Memory: ✅ 42.880MB (SLO: <46.000MB -6.8%) vs baseline: +4.7% ✅ ospathjoin_noaspectTime: ✅ 630.014µs (SLO: <700.000µs -10.0%) vs baseline: -1.3% Memory: ✅ 42.762MB (SLO: <46.000MB -7.0%) vs baseline: +5.3% ✅ ospathnormcase_aspectTime: ✅ 349.108µs (SLO: <700.000µs 📉 -50.1%) vs baseline: +0.3% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +5.0% ✅ ospathnormcase_noaspectTime: ✅ 354.265µs (SLO: <700.000µs 📉 -49.4%) vs baseline: -1.1% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +5.4% ✅ ospathsplit_aspectTime: ✅ 491.910µs (SLO: <700.000µs 📉 -29.7%) vs baseline: +0.6% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.9% ✅ ospathsplit_noaspectTime: ✅ 502.976µs (SLO: <700.000µs 📉 -28.1%) vs baseline: +0.7% Memory: ✅ 42.821MB (SLO: <46.000MB -6.9%) vs baseline: +5.1% ✅ ospathsplitdrive_aspectTime: ✅ 375.140µs (SLO: <700.000µs 📉 -46.4%) vs baseline: -0.6% Memory: ✅ 42.841MB (SLO: <46.000MB -6.9%) vs baseline: +4.7% ✅ ospathsplitdrive_noaspectTime: ✅ 73.005µs (SLO: <700.000µs 📉 -89.6%) vs baseline: -0.2% Memory: ✅ 42.861MB (SLO: <46.000MB -6.8%) vs baseline: +4.9% ✅ ospathsplitext_aspectTime: ✅ 457.053µs (SLO: <700.000µs 📉 -34.7%) vs baseline: -0.3% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +5.3% ✅ ospathsplitext_noaspectTime: ✅ 463.958µs (SLO: <700.000µs 📉 -33.7%) vs baseline: -0.2% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +5.3%
|
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
devflow unqueued this merge request: It did not become mergeable within the expected time |
f52d21a
into
main
Description
We add missing typing information for the bytecode utilities such as function wrapping and injection.
Additional Notes
Changes contributed by Claude Code.