refactor(profiling): add explicit casts to avoid narrowing conversions#16571
Draft
KowalskiThomas wants to merge 3 commits intomainfrom
Draft
refactor(profiling): add explicit casts to avoid narrowing conversions#16571KowalskiThomas wants to merge 3 commits intomainfrom
KowalskiThomas wants to merge 3 commits intomainfrom
Conversation
Use explicit static_cast where implicit narrowing conversions occur: - danger.cc: Cast page calculations to safe_memcpy_return_t - mirrors.cc: Cast table_size calculation to ssize_t - greenlets.cc: Cast count to int before adding - stack_renderer.cpp: Cast microsecond_t to int64_t for push_* calls - vm.cc: Cast size_t to off_t for ftruncate, riovcnt to int for pwritev - uploader.cpp: Cast len to std::streamsize for write() - frame.cc: Cast offsetof result to int - sampler.cpp: Cast uint64_t to double before subtraction Fixes clang-tidy bugprone-narrowing-conversions warnings.
Codeowners resolved as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
https://datadoghq.atlassian.net/browse/PROF-13775
Use explicit static_cast where implicit narrowing conversions occur:
Fixes clang-tidy bugprone-narrowing-conversions warnings.