-
Notifications
You must be signed in to change notification settings - Fork 477
fix(celery): stop native runtime before celery daemonization #16050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+56
−0
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
c0608b4
fix(forksafe): delay fork hook on celery daemonization
VianneyRuhlmann 81826c9
chore(forksafe): remove unused variable
VianneyRuhlmann ccbd34a
fix(celery): shutdown tokio runtime before closing fds
VianneyRuhlmann 125aac0
revert changes to forksafe
VianneyRuhlmann 5ad30bd
remove unused import
VianneyRuhlmann 79bb258
add release note
VianneyRuhlmann ab83ff2
Update releasenotes/notes/fix-celery-panic-03dd47d624a6d447.yaml
VianneyRuhlmann 8fb21a5
chore(celery): update unwrapped function
VianneyRuhlmann 91b81a8
chore(celery): add regression test
VianneyRuhlmann 1d64e1e
chore(lint): ruff format
VianneyRuhlmann b09572d
Merge branch 'main' into vianney/fix-celery-panic
VianneyRuhlmann 4f9e569
chore(celery): use fork hooks
VianneyRuhlmann d8aee09
Merge branch 'main' into vianney/fix-celery-panic
emmettbutler f8a4eab
chore(lint): unused import
VianneyRuhlmann a587c3a
Merge branch 'main' into vianney/fix-celery-panic
VianneyRuhlmann 4afc27e
Update ddtrace/contrib/internal/celery/app.py
VianneyRuhlmann accd6b5
Update tests/contrib/celery/test_integration.py
VianneyRuhlmann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| --- | ||
| fixes: | ||
| - | | ||
| celery: This fix resolves panics in the NativeWriter caused by celery closing file descriptors when starting beat. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.